Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade gambit and fix C++ issue #24012

Closed
jdemeyer opened this issue Oct 11, 2017 · 9 comments
Closed

Upgrade gambit and fix C++ issue #24012

jdemeyer opened this issue Oct 11, 2017 · 9 comments
Labels
c: packages: optional p: major / 3 t: bug
Milestone
sage-8.1

Comments

@jdemeyer
Copy link

The current gambit fails to compile with GCC-7.2.0

Upstream fix: gambitproject/gambit@b911156 (see also issue 220)

Tarball: https://downloads.sourceforge.net/project/gambit/gambit15/15.1.1/gambit-15.1.1.tar.gz?r=https%3A%2F%2Fsourceforge.net%2Fprojects%2Fgambit%2Ffiles%2Fgambit15%2F15.1.1&ts=1507718641&use_mirror=kent

Upstream: Fixed upstream, but not in a stable release.

Component: packages: optional

Author: Jeroen Demeyer

Branch/Commit: 6fc099e

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24012
@jdemeyer jdemeyer added this to the sage-8.1 milestone Oct 11, 2017
@jdemeyer
Copy link
Author

Author: Jeroen Demeyer

@jdemeyer

This comment has been minimized.

Sign in to view
@jdemeyer
Copy link
Author

Branch: u/jdemeyer/upgrade_gambit_and_fix_c___issue

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 11, 2017

Branch pushed to git repo; I updated commit sha1. New commits:

6fc099eFix doctests for gambit-15.1.1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 11, 2017

Commit: 6fc099e

@tscrim

This comment has been minimized.

Sign in to view
@tscrim
Copy link
Collaborator

tscrim commented Oct 11, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Oct 11, 2017

comment:5

LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 20, 2017

Changed branch from u/jdemeyer/upgrade_gambit_and_fix_c___issue to 6fc099e

@vbraun vbraun closed this as completed in 1b9d4b2 Oct 20, 2017
@jhpalmieri jhpalmieri mentioned this issue Oct 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: packages: optional p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.1
Development

No branches or pull requests
3 participants
@vbraun @tscrim @jdemeyer