Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Absolute import when importing string #24242

Closed
jdemeyer opened this issue Nov 19, 2017 · 8 comments
Closed

Absolute import when importing string #24242

jdemeyer opened this issue Nov 19, 2017 · 8 comments

Comments

@jdemeyer
Copy link

A few Sage modules import the Python module string. Since this name is so generic, it might conflict with submodules inside Sage (this happened in #24222). So it's better to use from future import absolute_import.

Component: misc

Author: Jeroen Demeyer

Branch/Commit: 55a76ce

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24242

@jdemeyer jdemeyer added this to the sage-8.1 milestone Nov 19, 2017
@jdemeyer
Copy link
Author

@jdemeyer
Copy link
Author

Commit: 55a76ce

@jdemeyer
Copy link
Author

New commits:

55a76ceAdd absolute_import in a few places

@jdemeyer

This comment has been minimized.

@tscrim
Copy link
Collaborator

tscrim commented Nov 19, 2017

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Nov 19, 2017

comment:3

LGTM.

@embray
Copy link
Contributor

embray commented Nov 20, 2017

comment:4

I thought at some point we had agreed to just put from future import absolute_import in every module. It is much better anyways than the old import semantics.

@vbraun
Copy link
Member

vbraun commented Dec 11, 2017

Changed branch from u/jdemeyer/absolute_import_when_importing_string to 55a76ce

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants