-
-
Notifications
You must be signed in to change notification settings - Fork 480
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Absolute import when importing string #24242
Labels
Milestone
Comments
Commit: |
New commits:
|
This comment has been minimized.
This comment has been minimized.
Reviewer: Travis Scrimshaw |
comment:3
LGTM. |
comment:4
I thought at some point we had agreed to just put |
Changed branch from u/jdemeyer/absolute_import_when_importing_string to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A few Sage modules import the Python module
string
. Since this name is so generic, it might conflict with submodules inside Sage (this happened in #24222). So it's better to usefrom
futureimport absolute_import
.Component: misc
Author: Jeroen Demeyer
Branch/Commit:
55a76ce
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/24242
The text was updated successfully, but these errors were encountered: