Improve the output of repr_pretty_Hrepresentation for Polyhedron

[jplab]

Following #22572, we can improve the output of the pretty print:

    sage: Cube = polytopes.cube()
    sage: TCube = Cube.truncation()
    sage: Nice_repr = TCube.repr_pretty_Hrepresentation(separator='\n')
    sage: print(Nice_repr)
    1 >= x0
    1 >= x1
    3*x1 + 7 >= 3*x0 + 3*x2
    x0 + 1 >= 0
    x1 + 1 >= 0
    3*x0 + 7 >= 3*x1 + 3*x2
    3*x0 + 3*x1 + 7 >= 3*x2
    3*x0 + 3*x2 + 7 >= 3*x1
    3*x0 + 3*x1 + 3*x2 + 7 >= 0
    x2 + 1 >= 0
    1 >= x2
    3*x1 + 3*x2 + 7 >= 3*x0
    3*x2 + 7 >= 3*x0 + 3*x1
    7 >= 3*x0 + 3*x1 + 3*x2

In the new version it gives:

    sage: print(TCube.Hrepresentation_str())
                    -x0 >= -1 
                    -x1 >= -1 
    -3*x0 + 3*x1 - 3*x2 >= -7 
                     x0 >= -1 
                     x1 >= -1 
     3*x0 - 3*x1 - 3*x2 >= -7 
     3*x0 + 3*x1 - 3*x2 >= -7 
     3*x0 - 3*x1 + 3*x2 >= -7 
     3*x0 + 3*x1 + 3*x2 >= -7 
                     x2 >= -1 
                    -x2 >= -1 
    -3*x0 + 3*x1 + 3*x2 >= -7 
    -3*x0 - 3*x1 + 3*x2 >= -7 
    -3*x0 - 3*x1 - 3*x2 >= -7

    sage: print(TCube.Hrepresentation_str(latex=True))
    \begin{array}{rcl}
                                   -x_{0} & \geq & -1 \\
                                   -x_{1} & \geq & -1 \\
    -3 \, x_{0} + 3 \, x_{1} - 3 \, x_{2} & \geq & -7 \\
                                    x_{0} & \geq & -1 \\
                                    x_{1} & \geq & -1 \\
     3 \, x_{0} - 3 \, x_{1} - 3 \, x_{2} & \geq & -7 \\
     3 \, x_{0} + 3 \, x_{1} - 3 \, x_{2} & \geq & -7 \\
     3 \, x_{0} - 3 \, x_{1} + 3 \, x_{2} & \geq & -7 \\
     3 \, x_{0} + 3 \, x_{1} + 3 \, x_{2} & \geq & -7 \\
                                    x_{2} & \geq & -1 \\
                                   -x_{2} & \geq & -1 \\
    -3 \, x_{0} + 3 \, x_{1} + 3 \, x_{2} & \geq & -7 \\
    -3 \, x_{0} - 3 \, x_{1} + 3 \, x_{2} & \geq & -7 \\
    -3 \, x_{0} - 3 \, x_{1} - 3 \, x_{2} & \geq & -7 
    \end{array}

The style parameter allows to change the way to print the H-relations:

sage: P = polytopes.permutahedron(3)
sage: print(P.Hrepresentation_str(style='<='))
-x0 - x1 - x2 == -6 
      x1 + x2 <=  5 
           x2 <=  3 
           x1 <=  3 
          -x1 <= -1 
     -x1 - x2 <= -3 
          -x2 <= -1
sage: print(P.Hrepresentation_str(style='positive'))
x0 + x1 + x2 == 6       
           5 >= x1 + x2 
           3 >= x2      
           3 >= x1      
          x1 >= 1       
     x1 + x2 >= 3       
          x2 >= 1

In order to make the function more apparent, deprecation of the current function is perhaps a good idea and change the name to Hrepresentation_str.

Depends on #22572

CC: @videlec @mo271 @tscrim

Component: geometry

Keywords: days93, IMA-PolyGeom

Author: Jean-Philippe Labbé

Branch: b1ae583

Reviewer: Moritz Firsching, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/24837

[jplab]

Dependencies: #22572

[jplab]

comment:1

Once the tutorial is merged in #22572, we should change the "tips" page accordingly...

---

New commits:

7cf1a56

first version

[jplab]

Commit: 7cf1a56

[jplab]

Branch: u/jipilab/24837

[jplab]

Author: Jean-Philippe Labbé

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

132c27a

Merge branch 'develop' into 24837

[sagetrac-git]

Changed commit from 7cf1a56 to 132c27a

[sagetrac-git]

Changed commit from 132c27a to 3fea478

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

231cd56	deleted trailing whitespace
f685c64	fixed some typos in lectures.rst
7f5e125	fixed typos in polyhedra_quickref.rst
bd6c356	LateX -> LaTeX in polytope_tikz.rst
b1ce45b	Several other corrections
d526f70	renamed tutorial files
d7896f8	Merge branch 'develop' into 22572
597b802	Merge branch sage8.2.rc1 into 22572
066c7a5	Merge branch tutorial into 24837
3fea478	Adapted tutorial

[jplab]

Changed keywords from days93 to days93, IMA-PolyGeom

[mo271]

Changed branch from u/jipilab/24837 to u/moritz/24837

[mo271]

Reviewer: Moritz Firsching

[mo271]

Changed commit from 3fea478 to f98b24a

[mo271]

comment:8

There was one doctest failing and a bit whitespace left. Other than that I think this is good to go. Set it on positive review on my behalf if you agree!

---

New commits:

f98b24a

fix a doctest and remove trailing whitespace

[jplab]

comment:9

The last bot test looks good. I'm setting it to positive review.

[vbraun]

comment:11

Merge conflict

[jplab]

comment:13

Ping!

[tscrim]

Changed reviewer from Moritz Firsching to Moritz Firsching, Travis Scrimshaw

[tscrim]

comment:14

Two trivial failures; see patchbot for details:

sage -t --long --warn-long 49.3 src/doc/en/thematic_tutorials/geometry/tips.rst  # 2 doctests failed

[sagetrac-git]

Changed commit from e6ba9cc to 736f60f

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

736f60f

fixed doctests

[jplab]

comment:16

Should now work...

[jplab]

comment:17

There are two pyflakes warnings about the usage of QQ and RDF.

Question: if they are used in doctests, that's not necessary to import them, correct?

If so, I'd just remove them...

[tscrim]

comment:18

Replying to @jplab:

There are two pyflakes warnings about the usage of QQ and RDF.

Question: if they are used in doctests, that's not necessary to import them, correct?

If so, I'd just remove them...

Please do. What is imported in a file and what used in doctests, which is the global namespace, are essentially independent. Once you remove them, you can set a positive review on my behalf.

[jplab]

comment:19

Replying to @tscrim:

Replying to @jplab:

There are two pyflakes warnings about the usage of QQ and RDF.

Question: if they are used in doctests, that's not necessary to import them, correct?

If so, I'd just remove them...

Please do. What is imported in a file and what used in doctests, which is the global namespace, are essentially independent. Once you remove them, you can set a positive review on my behalf.

Sounds good! I just wanted to make sure...

[sagetrac-git]

Changed commit from 736f60f to b1ae583

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b1ae583

Removed unnecessary import

[jplab]

comment:21

Done! Thanks for the review!

[videlec]

comment:22

update milestone 8.3 -> 8.4

[vbraun]

Changed branch from u/jipilab/24837 to b1ae583

[dkrenn]

Changed commit from b1ae583 to none

[dkrenn]

comment:24

There is a follow-up ticket #26141 concerning the code quality.