-
-
Notifications
You must be signed in to change notification settings - Fork 481
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert mandelbrot/julia interact to jupyter notebook #24994
Comments
comment:1
work in progress, not yet working as expected.. New commits:
|
Commit: |
Branch: public/24994 |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:5
ok, working now. Except 3 failing doctests that I just fail to write using ellipsis ! |
Author: Frédéric Chapoton |
Branch pushed to git repo; I updated commit sha1. New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
This is bad:
The problem is that you are changing and returning a unique global object. Instead of having
it would be better to just define Can you explain the |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
Better like that ? |
comment:12
ping ? |
comment:13
ping ? |
comment:31
Is this still "needing work", Jeroen ? This is the place where docbuild currently fails on the python3 patchbot. See |
Changed dependencies from #25074 to none |
comment:33
This is working fine, the only issue is comment:29 |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:35
OK, I'll work on this today. |
Dependencies: #25373 |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
Reviewer: Frédéric Chapoton, Jeroen Demeyer |
comment:41
I think I can reasonably set this to positive now. |
Changed branch from public/24994 to |
as another step to python3
Depends on #25373
CC: @bbarros50 @bhutz @sagetrac-atowsley @kcrisman @embray @jdemeyer @jm58660
Component: notebook
Author: Frédéric Chapoton, Jeroen Demeyer
Branch/Commit:
4de168d
Reviewer: Frédéric Chapoton, Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/24994
The text was updated successfully, but these errors were encountered: