Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert mandelbrot/julia interact to jupyter notebook #24994

Closed
fchapoton opened this issue Mar 17, 2018 · 56 comments
Closed

convert mandelbrot/julia interact to jupyter notebook #24994

fchapoton opened this issue Mar 17, 2018 · 56 comments

Comments

@fchapoton
Copy link
Contributor

as another step to python3

Depends on #25373

CC: @bbarros50 @bhutz @sagetrac-atowsley @kcrisman @embray @jdemeyer @jm58660

Component: notebook

Author: Frédéric Chapoton, Jeroen Demeyer

Branch/Commit: 4de168d

Reviewer: Frédéric Chapoton, Jeroen Demeyer

Issue created by migration from https://trac.sagemath.org/ticket/24994

@fchapoton fchapoton added this to the sage-8.2 milestone Mar 17, 2018
@fchapoton
Copy link
Contributor Author

comment:1

work in progress, not yet working as expected..


New commits:

a9e184dfirst tentative of conversion of mandelbrot interact to jupyter interact

@fchapoton
Copy link
Contributor Author

Commit: a9e184d

@fchapoton
Copy link
Contributor Author

Branch: public/24994

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

52ce4a5second pass at interactive mandelbrot/julia in ipython notebook

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 17, 2018

Changed commit from a9e184d to 52ce4a5

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 17, 2018

Changed commit from 52ce4a5 to c65a01c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

c65a01cfixing colors and other details

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 17, 2018

Changed commit from c65a01c to 7cbf77b

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

7cbf77btrying to fix doctests..

@fchapoton
Copy link
Contributor Author

comment:5

ok, working now. Except 3 failing doctests that I just fail to write using ellipsis !

@fchapoton
Copy link
Contributor Author

Author: Frédéric Chapoton

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

4467110pep8 and pyflakes cleanup

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 17, 2018

Changed commit from 7cbf77b to 4467110

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 17, 2018

Changed commit from 4467110 to 588ac04

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 17, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

588ac04fixing doctests (ugly)

@jdemeyer
Copy link

comment:9

This is bad:

M = mandelbrot_interact
...adjust various attributes of M...
return M

The problem is that you are changing and returning a unique global object. Instead of having

@interact.widget
def mandelbrot_interact(...

it would be better to just define mandelbrot_interact as an ordinary function and call interact.widget() inside the mandelbrot_plot function. That way, you end up with non-unique widgets.

Can you explain the <CSI-2K> appearing in the doctests? I feel uncomfortable accepting that without knowing where it comes from.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 21, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

8bdbb0dmade the suggested changes

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 21, 2018

Changed commit from 588ac04 to 8bdbb0d

@fchapoton
Copy link
Contributor Author

comment:11

Better like that ?

@fchapoton
Copy link
Contributor Author

comment:12

ping ?

@fchapoton
Copy link
Contributor Author

comment:13

ping ?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

ad085dcupgrade to ipywidgets 7.2.0 and widgetsnbextension 3.20
4b925befirst tentative of conversion of mandelbrot interact to jupyter interact

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 26, 2018

Changed commit from 8bdbb0d to 4b925be

@fchapoton
Copy link
Contributor Author

comment:31

Is this still "needing work", Jeroen ?

This is the place where docbuild currently fails on the python3 patchbot. See

https://patchbot.sagemath.org/log/0/Ubuntu/18.04/x86_64/4.15.0-20-generic/petitbonum/2018-05-15%2012:37:45?plugin=docbuild

@fchapoton
Copy link
Contributor Author

Changed dependencies from #25074 to none

@fchapoton fchapoton modified the milestones: sage-8.2, sage-8.3 May 15, 2018
@fchapoton
Copy link
Contributor Author

comment:33

This is working fine, the only issue is comment:29

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8143016first tentative of conversion of mandelbrot interact to jupyter interact

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2018

Changed commit from 4b925be to 8143016

@jdemeyer
Copy link

comment:35

OK, I'll work on this today.

@jdemeyer
Copy link

Dependencies: #25373

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2018

Changed commit from 8143016 to e4523c4

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

2e75d4cAdd IPython support for Cython functions
f25a0e8first tentative of conversion of mandelbrot interact to jupyter interact
e4523c4Improve Mandelbrot/Julia interact

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2018

Changed commit from e4523c4 to 56b571f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

56b571fImprove Mandelbrot/Julia interact

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

4de168dImprove Mandelbrot/Julia interact

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented May 16, 2018

Changed commit from 56b571f to 4de168d

@fchapoton
Copy link
Contributor Author

Reviewer: Frédéric Chapoton, Jeroen Demeyer

@fchapoton
Copy link
Contributor Author

comment:41

I think I can reasonably set this to positive now.

@vbraun
Copy link
Member

vbraun commented May 27, 2018

Changed branch from public/24994 to 4de168d

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants