Add DESTDIR support for gap

[embray]

Implements #24024 for gap; this one is slightly non-trivial.

Depends on #24599
Depends on #25039
Depends on #23733

Component: build

Keywords: destdir gap

Author: Erik Bray

Branch/Commit: u/embray/build/destdir-gap @ ee25fe7

Issue created by migration from https://trac.sagemath.org/ticket/25044

[jdemeyer]

comment:2

Why not use sdh_configure here?

[embray]

comment:3

Hmm, for some reason I thought it wasn't a standard autoconf configure, but it looks like it is, actually. I don't know why it's being passed some PREFIX argument. That doesn't seem to do anything.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

1af0242

Use sdh_configure; clean up some superfluous arguments to the configure script

[sagetrac-git]

Changed commit from 990b6ad to 1af0242

[embray]

Changed dependencies from #24599, #25039 to #24599, #25039, #23733

[embray]

comment:5

(already merges without conflict with #23733)

[embray]

comment:6

This appears to have some kind of problem installing gap.sh...

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b4ecda9	trac 23733: deprecate SAGE64 and CFLAG64
905e4d4	Stop supporting SAGE64 except in Numpy
4f85314	Merge branch 'u/jdemeyer/no-sage64' into u/embray/build/destdir-gap
c14afaa	turns out bin/gap.sh is a symlink to either gap-default64.sh or gap-default32.sh (only one or the other should exist). rather than add explicit support for dereferencing symlinks, for now just copy the real file

[sagetrac-git]

Changed commit from 1af0242 to c14afaa

[saraedum]

Work Issues: merge conflicts

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

b03b468	Update to use sage-dist-helpers; add DESTDIR support where possible
19a00c4	update package version for buildbot
0a0ae72	Use sdh_configure; clean up some superfluous arguments to the configure script
6d1493a	turns out bin/gap.sh is a symlink to either gap-default64.sh or gap-default32.sh (only one or the other should exist). rather than add explicit support for dereferencing symlinks, for now just copy the real file

[sagetrac-git]

Changed commit from c14afaa to 6d1493a

[embray]

comment:12

I think it should be good now.

[embray]

Changed work issues from merge conflicts to none

[embray]

comment:13

I believe this issue can reasonably be addressed for Sage 8.4.

[jdemeyer]

comment:14

Since SAGE_GAP is no longer used in the script, it would be more clear to replace

SAGE_GAP="$SAGE_LOCAL/gap"
INSTALL_DIR="$SAGE_GAP/$GAP_DIR"

by

INSTALL_DIR="$SAGE_LOCAL/gap/$GAP_DIR"

[jdemeyer]

comment:15

I would remove

[ -f bin/gap.sh ] || sdh_die "Error building GAP ('gap.sh' not found)."

You have a commit message turns out bin/gap.sh is a symlink to either gap-default64.sh or gap-default32.sh (only one or the other should exist). rather than add explicit support for dereferencing symlinks, for now just copy the real file. I would rather see something like that in a comment in the script, otherwise it's quite obscure what sdh_install -T bin/gap-default*.sh "$SAGE_LOCAL/bin/gap" does.

Given that we have sage-legacy-uninstall, shouldn't this be moved there?

rm -rf "$INSTALL_DIR"
rm -f "$SAGE_LOCAL/gap/latest"
rm -f "$SAGE_LOCAL/bin/gap"

(just a question, if there is a good reason to keep it there: fine for me)

[embray]

comment:17

Replying to @jdemeyer:

Given that we have sage-legacy-uninstall, shouldn't this be moved there?

rm -rf "$INSTALL_DIR"
rm -f "$SAGE_LOCAL/gap/latest"
rm -f "$SAGE_LOCAL/bin/gap"

(just a question, if there is a good reason to keep it there: fine for me)

Yes, this ticket just predates that being merged; as long as this is still open it makes sense to go ahead and move that stuff into an spkg-legacy-uninstall.

[sagetrac-git]

Changed commit from 6d1493a to ee25fe7

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

25e9ae1	Update to use sage-dist-helpers; add DESTDIR support where possible
392056a	update package version for buildbot
2da622a	Use sdh_configure; clean up some superfluous arguments to the configure script
b50ce9f	turns out bin/gap.sh is a symlink to either gap-default64.sh or gap-default32.sh (only one or the other should exist). rather than add explicit support for dereferencing symlinks, for now just copy the real file
448b6de	some review details
ee25fe7	move the old cleanup code to an spkg-legacy-uninstall

[embray]

comment:19

Done all of the above.

[embray]

comment:20

Bump.

[embray]

comment:22

This is also implemented by #22626 which supersedes this.