-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DESTDIR support to additional Python packages; upgrade pip to latest patch release #25051
Comments
Work Issues: merge conflicts |
Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:
|
comment:5
Rebased. New commits:
|
Changed work issues from merge conflicts to none |
comment:7
For |
comment:8
def finalize_options(self):
orig.install.finalize_options(self)
if self.root:
self.single_version_externally_managed = True
elif self.single_version_externally_managed:
if not self.root and not self.record:
raise DistutilsArgError(
"You must specify --record or --root when building system"
" packages"
) Maybe you want to keep |
Reviewer: Jeroen Demeyer |
comment:10
If you're changing |
comment:11
Replying to @jdemeyer:
+1 Replying to @jdemeyer:
What I'm not sure about here (I haven't tried it) is if Replying to @jdemeyer:
Yeah, the thought did cross my mind. Might as well. |
This comment has been minimized.
This comment has been minimized.
comment:14
Testing... |
comment:16
I'm instead dealing with cysignals in #25092. |
Changed branch from u/embray/build/destdir-python-misc to u/jdemeyer/build/destdir-python-misc |
This comment has been minimized.
This comment has been minimized.
comment:19
Making this ticket a blocker: after PyPI disabled TLSv1 in early April 2018, |
comment:20
Have you actually verified this? We don't use system python... |
comment:21
This doesn't have anything to do with the system Python. It has to do with the server settings on PyPI itself, and hence how pip connects to it. I was aware of this issue myself but I didn't really think about it in terms of Sage. Anyways, one can also manually download a tarball from PyPI and install it with pip. |
comment:22
Replying to @vbraun:
Without this ticket, on macOS 10.10.5, since ~10 April 2018, After applying this ticket, it became possible again. |
Changed branch from u/jdemeyer/build/destdir-python-misc to |
These are packages for which the
spkg-install
requires more than justsdh_pip_install
. See commit message for more details.Also upgrades pip to the latest patch release (9.0.3) while we're at it.
Upstream tarball: https://pypi.python.org/packages/c4/44/e6b8056b6c8f2bfd1445cc9990f478930d8e3459e9dbf5b8e2d2922d64d3/pip-9.0.3.tar.gz
Component: build
Keywords: destdir cysignals pip setuptools pillow numpy
Author: Erik Bray
Branch/Commit:
5bdfd4e
Reviewer: Jeroen Demeyer
Issue created by migration from https://trac.sagemath.org/ticket/25051
The text was updated successfully, but these errors were encountered: