Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polygon3d ignores the "alpha" (and equivalent "opacity") argument #25095

Closed
yuan-zhou opened this issue Apr 3, 2018 · 20 comments
Closed

polygon3d ignores the "alpha" (and equivalent "opacity") argument #25095

yuan-zhou opened this issue Apr 3, 2018 · 20 comments

Comments

@yuan-zhou
Copy link

The methods sage.plot.plot3d.shapes2.polygon3d and sage.plot.plot3d.shapes2.polygons3d have the keyword argument "alpha" (as well as the equivalent, outdated "opacity" argument). However it is not passed to the plot function. For example,

polygon3d([[1, 2, 3], [0,1,0], [1,0,1], [3,0,0]], color=(0,1,0), alpha=0.5)

or

polygon3d([[1, 2, 3], [0,1,0], [1,0,1], [3,0,0]], color=(0,1,0), opacity=0.5)

is treated as opacity=1.

Related tickets:
#21984
Update: The argument "alpha" is equivalent to "opacity" in all the 3d plot functions, such as point3d, line3d, sphere, icosahedron, tetrahedron, dodecahedron, polygon3d, polygons3d, bezier3d, parametric_plot3d, revolution_plot3d, `arrow3d', etc.

#260, #9491, #15729, #21984, #23104.

CC: @mkoeppe @slel

Component: graphics

Keywords: IMA-PolyGeom, alpha, opacity, transparency, 3d

Author: Yuan Zhou

Branch/Commit: 93fe1e2

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/25095

@yuan-zhou yuan-zhou added this to the sage-8.2 milestone Apr 3, 2018
@yuan-zhou
Copy link
Author

@yuan-zhou
Copy link
Author

New commits:

f96943fpass extra kwds such as opacity in IndexFaceSet
8948ca2remove obsolete docstring

@yuan-zhou
Copy link
Author

Author: Yuan Zhou

@yuan-zhou
Copy link
Author

Commit: 8948ca2

@slel
Copy link
Member

slel commented Apr 4, 2018

comment:3

For consistency, use alpha instead of opacity, see #21984.

@slel
Copy link
Member

slel commented Apr 4, 2018

Changed keywords from IMA-PolyGeom to IMA-PolyGeom, alpha, opacity, transparency, 3d

@slel
Copy link
Member

slel commented Apr 4, 2018

comment:4

Related tickets: #260, #9491, #15729, #21984, #23104.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2018

Changed commit from 8948ca2 to 6d6a251

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

6d6a251make keyword alpha equivalent to opacity

@yuan-zhou

This comment has been minimized.

@yuan-zhou
Copy link
Author

New commits:

6d6a251make keyword alpha equivalent to opacity

@yuan-zhou yuan-zhou changed the title polygon3d ignores the "opacity" argument polygon3d ignores the "alpha" (and equivalent "opacity") argument Apr 4, 2018
@yuan-zhou

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2018

Changed commit from 6d6a251 to e01426f

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

e01426fimport decorator rename_keyword

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

93fe1e2keywords alpha and opacity play the same role in all plot3d functions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2018

Changed commit from e01426f to 93fe1e2

@yuan-zhou

This comment has been minimized.

@jplab
Copy link

jplab commented Apr 12, 2018

Reviewer: Jean-Philippe Labbé

@jplab
Copy link

jplab commented Apr 12, 2018

comment:11

Looks good to me.

@vbraun
Copy link
Member

vbraun commented May 12, 2018

Changed branch from u/yzh/polygon3d_ignores_the__opacity__argument to 93fe1e2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants