Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add DESTDIR support for gfan, lcalc, ratpoints, rubiks, symmetrica #25100

Closed
embray opened this issue Apr 4, 2018 · 24 comments
Closed

Add DESTDIR support for gfan, lcalc, ratpoints, rubiks, symmetrica #25100

embray opened this issue Apr 4, 2018 · 24 comments

Comments

@embray
Copy link
Contributor

embray commented Apr 4, 2018

Updates several miscellaneous packages for #24024:

  • gfan
  • lcalc
  • ratpoints
  • rubiks
  • symmetrica

These packages don't specifically have anything in common here except for being standard packages with somewhat unusual custom install scripts, but that aren't particularly complicated either.

Component: build

Keywords: destdir gfan lcalc ratpoints rubiks symmetrica

Author: Erik Bray

Branch/Commit: 6c64fca

Reviewer: Frédéric Chapoton

Issue created by migration from https://trac.sagemath.org/ticket/25100

@embray embray added this to the sage-8.2 milestone Apr 4, 2018
@embray
Copy link
Contributor Author

embray commented Apr 4, 2018

Changed keywords from none to destdir gfan lcalc ratpoints rubiks symmetrica

@embray
Copy link
Contributor Author

embray commented Apr 4, 2018

Changed dependencies from #25039 to #25039, #23733

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

b4ecda9trac 23733: deprecate SAGE64 and CFLAG64
905e4d4Stop supporting SAGE64 except in Numpy
938b8bfMerge branch 'u/jdemeyer/no-sage64' into u/embray/build/destdir-symmetrica

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Apr 4, 2018

Changed commit from d783235 to 938b8bf

@embray embray modified the milestones: sage-8.2, sage-8.3 Apr 26, 2018
@saraedum
Copy link
Member

Work Issues: merge conflicts

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 17, 2018

Changed commit from 938b8bf to 85ecca2

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jul 17, 2018

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

85ecca2Updates several miscellaneous packages for #24024:

@embray
Copy link
Contributor Author

embray commented Jul 17, 2018

comment:7

Should be good.

@embray
Copy link
Contributor Author

embray commented Jul 17, 2018

Changed work issues from merge conflicts to none

@embray
Copy link
Contributor Author

embray commented Jul 18, 2018

comment:8

I believe this issue can reasonably be addressed for Sage 8.4.

@embray embray modified the milestones: sage-8.3, sage-8.4 Jul 18, 2018
@embray embray modified the milestones: sage-8.4, sage-8.5 Oct 28, 2018
@embray
Copy link
Contributor Author

embray commented Dec 28, 2018

comment:10

Retargeting some of my tickets (somewhat optimistically for now).

@embray embray modified the milestones: sage-8.5, sage-8.7 Dec 28, 2018
@fchapoton
Copy link
Contributor

comment:11

red branch

@fchapoton
Copy link
Contributor

Changed dependencies from #25039, #23733 to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2019

Changed commit from 85ecca2 to 8635c52

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 9, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

8635c52Updates several miscellaneous packages for #24024:

@embray
Copy link
Contributor Author

embray commented Jan 9, 2019

comment:13

Updated. Would be nice to get some review on this so I don't have to rebase it again in another 9 months :)

@fchapoton
Copy link
Contributor

comment:14

is this normal (in ratpoints):
"$SAGE_DESTDIR$SAGE_LOCAL"
or should it be
"$SAGE_DESTDIR_LOCAL" ?

@embray
Copy link
Contributor Author

embray commented Jan 10, 2019

comment:15

The latter is just a synonym for the former, so it's fine (I think last time I worked on this ticket the latter didn't exist yet). I don't think it's worth changing unless otherwise modifying something else in the file.

@fchapoton
Copy link
Contributor

comment:16

for the sake of future grep search, please use the second form (nitpick)

otherwise, looks good to me. Once done, you can set to positive.

@embray
Copy link
Contributor Author

embray commented Jan 10, 2019

comment:17

If that's what it'll take; might as well.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

6c64fcaUse $SAGE_DESTDIR_LOCAL instead in ratpoints

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Jan 10, 2019

Changed commit from 8635c52 to 6c64fca

@embray
Copy link
Contributor Author

embray commented Jan 10, 2019

Reviewer: Frédéric Chapoton

@vbraun
Copy link
Member

vbraun commented Jan 23, 2019

Changed branch from u/embray/build/destdir-symmetrica to 6c64fca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants