Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade latte_int to 1.7.5 #26190

Closed
mkoeppe opened this issue Sep 5, 2018 · 17 comments
Closed

Upgrade latte_int to 1.7.5 #26190

mkoeppe opened this issue Sep 5, 2018 · 17 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 5, 2018

the tarball is here:
https://github.com/latte-int/latte/releases/download/version_1_7_5/latte-int-1.7.5.tar.gz

CC: @tscrim

Component: packages: optional

Work Issues: Back out #18887, fixed upstream

Author: Matthias Koeppe

Branch/Commit: 9673bbb

Reviewer: Dima Pasechnik, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26190

@mkoeppe mkoeppe added this to the sage-8.4 milestone Sep 5, 2018
@dimpase
Copy link
Member

dimpase commented Sep 15, 2018

comment:2

1.7.3 does not build on FreeBSD 12 (also without Lidia, which is broken there), but 1.7.5 does. So this is something needed for FreeBSD becoming a 1st tier platform (see #26249).

@dimpase
Copy link
Member

dimpase commented Oct 25, 2018

comment:3

please provide a link to the tarball in the ticket description.

@dimpase

This comment has been minimized.

@dimpase
Copy link
Member

dimpase commented Oct 25, 2018

New commits:

8c59f18bump up the version etc

@dimpase
Copy link
Member

dimpase commented Oct 25, 2018

Branch: public/packages/latte175update

@dimpase
Copy link
Member

dimpase commented Oct 25, 2018

Commit: 8c59f18

@dimpase
Copy link
Member

dimpase commented Oct 25, 2018

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Oct 25, 2018

comment:6

I've checked that this works on Linux x86_64 (also with SAGE_CHECK=yes) and on FreeBSD.
Please feel free to check it for yourself and make it positive review.

@dimpase
Copy link
Member

dimpase commented Oct 25, 2018

comment:7

marked as defect, as there are platforms for which it makes a difference from failure to working...

@dimpase dimpase modified the milestones: sage-8.4, sage-8.5 Oct 25, 2018
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 25, 2018

Work Issues: Back out #18887, fixed upstream

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 25, 2018

Branch pushed to git repo; I updated commit sha1. New commits:

9673bbbbacked out #18887

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Oct 25, 2018

Changed commit from 8c59f18 to 9673bbb

@dimpase
Copy link
Member

dimpase commented Oct 29, 2018

comment:11

ping?

@tscrim
Copy link
Collaborator

tscrim commented Oct 31, 2018

comment:12

I am ready to set a positive review unless Matthias has any other comments.

@tscrim
Copy link
Collaborator

tscrim commented Nov 6, 2018

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Travis Scrimshaw

@vbraun
Copy link
Member

vbraun commented Nov 7, 2018

Changed branch from public/packages/latte175update to 9673bbb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants