Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library of polytopes should allow specifying backend=... (follow-up) #26365

Closed
mkoeppe opened this issue Sep 30, 2018 · 8 comments
Closed

Library of polytopes should allow specifying backend=... (follow-up) #26365

mkoeppe opened this issue Sep 30, 2018 · 8 comments
Labels
c: geometry p: major / 3 t: bug
Milestone
sage-8.4

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Sep 30, 2018

Follow-up from #21937:

polytopes.cube forgets to pass on backend.

CC: @tscrim

Component: geometry

Author: Matthias Koeppe

Branch/Commit: 72c1742

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/26365
@mkoeppe mkoeppe added this to the sage-8.4 milestone Sep 30, 2018
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2018

Branch: u/mkoeppe/library_of_polytopes_should_allow_specifying_backend______follow_up_

@tscrim
Copy link
Collaborator

tscrim commented Sep 30, 2018

comment:2

Needs review?

New commits:

72c1742polytopes.cube: Pass on backend

@tscrim
Copy link
Collaborator

tscrim commented Sep 30, 2018

Commit: 72c1742

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Sep 30, 2018

Author: Matthias Koeppe

@mkoeppe

This comment has been minimized.

Sign in to view
@tscrim
Copy link
Collaborator

tscrim commented Sep 30, 2018

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Sep 30, 2018

comment:5

LGTM.

@vbraun
Copy link
Member

vbraun commented Oct 1, 2018

Changed branch from u/mkoeppe/library_of_polytopes_should_allow_specifying_backend______follow_up_ to 72c1742

@vbraun vbraun closed this as completed in 7c55d1c Oct 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: bug
Projects
None yet
Milestone
sage-8.4
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe