-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
py3: avoid sorting vertices and edges in method treewidth #27009
Comments
Commit: |
New commits:
|
Branch: public/27009_treewidth |
comment:2
Why do you use Other than that LGTM. |
comment:3
The graph is modified inside the loop over all vertices, so I cannot use an iterator here (at least it's safer this way). |
comment:4
Okay, thanks for the explanation. LGTM. |
Reviewer: Travis Scrimshaw |
comment:5
Thank you for the reviews and happy new year ! |
comment:6
Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist. |
Changed branch from public/27009_treewidth to |
We avoid sorting vertices, edges and connected components. The code is better this way, and this fixes a doctest error with py3.
CC: @tscrim @fchapoton
Component: graph theory
Author: David Coudert
Branch/Commit:
f830eb9
Reviewer: Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/27009
The text was updated successfully, but these errors were encountered: