Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

py3: avoid .vertices() in methods _ford_fulkerson, edge_cut, bounded_outdegree_orientation and gomory_hu_tree #27010

Closed
dcoudert opened this issue Jan 3, 2019 · 7 comments
Closed

py3: avoid .vertices() in methods _ford_fulkerson, edge_cut, bounded_outdegree_orientation and gomory_hu_tree #27010

dcoudert opened this issue Jan 3, 2019 · 7 comments
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Milestone
sage-8.7

Comments

@dcoudert
Copy link
Contributor

dcoudert commented Jan 3, 2019

We fix all doctests errors in py3 of methods bounded_outdegree_orientation and gomory_hu_tree of graph.py by avoiding calls to .vertices() in these methods and in methods edge_cut and _ford_fulkerson of generic_graph.py. This also fixes some doctests in generic_graph.py.

CC: @tscrim @fchapoton

Component: graph theory

Author: David Coudert

Branch/Commit: 0240367

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27010
@dcoudert dcoudert added this to the sage-8.6 milestone Jan 3, 2019
@dcoudert
Copy link
Contributor Author

dcoudert commented Jan 3, 2019

Commit: 0240367

@dcoudert
Copy link
Contributor Author

dcoudert commented Jan 3, 2019

Branch: public/27010_graph

@dcoudert
Copy link
Contributor Author

dcoudert commented Jan 3, 2019

New commits:

0240367trac #27010: save some calls to .vertices()

@tscrim
Copy link
Collaborator

tscrim commented Jan 3, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Jan 3, 2019

comment:2

LGTM.

@embray
Copy link
Contributor

embray commented Jan 15, 2019

comment:3

Retarging tickets optimistically to the next milestone. If you are responsible for this ticket (either its reporter or owner) and don't believe you are likely to complete this ticket before the next release (8.7) please retarget this ticket's milestone to sage-pending or sage-wishlist.

@embray embray modified the milestones: sage-8.6, sage-8.7 Jan 15, 2019
@vbraun
Copy link
Member

vbraun commented Jan 22, 2019

Changed branch from public/27010_graph to 0240367

@vbraun vbraun closed this as completed in 6521233 Jan 22, 2019
@mezzarobba mezzarobba mentioned this issue Feb 11, 2019
Closed
@dcoudert dcoudert mentioned this issue Jun 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: graph theory c: python3 p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.7
Development

No branches or pull requests
4 participants
@embray @vbraun @tscrim @dcoudert