Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement method gap of class PermutationGroupElement properly. #27234

Closed
soehms opened this issue Feb 7, 2019 · 7 comments
Closed

Implement method gap of class PermutationGroupElement properly. #27234

soehms opened this issue Feb 7, 2019 · 7 comments

Comments

@soehms
Copy link
Member

soehms commented Feb 7, 2019

This is a follow up ticket of #26750. In that ticket the method has been implemented as synonym of _gap_, since at that time libgap produced an error for large permutations.

┌────────────────────────────────────────────────────────────────────┐
│ SageMath version 8.5, Release Date: 2018-12-22                     │
│ Using Python 2.7.15. Type "help()" for help.                       │
└────────────────────────────────────────────────────────────────────┘
sage: P = PGU(8,2)
sage: p1, p2 = P.gens()
sage: libgap(p1)
python2: libgap.c:184: libgap_get_input: Assertion `strlen(libGAP_stdin_buffer) < length' failed.
Traceback (most recent call last):
...
ValueError: libGAP: Aborted

This error has been fixed in 8.6.beta0. Therefore, we may have gap using libgap, right now!

Component: group theory

Keywords: libgap, permutation

Author: Sebastian Oehms

Branch/Commit: 0e444c5

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/27234

@soehms soehms added this to the sage-8.7 milestone Feb 7, 2019
@soehms
Copy link
Member Author

soehms commented Feb 7, 2019

Branch: u/soehms/permgroup_element_gap_meth

@soehms
Copy link
Member Author

soehms commented Feb 7, 2019

New commits:

0e444c527234: initial version

@soehms
Copy link
Member Author

soehms commented Feb 7, 2019

Commit: 0e444c5

@tscrim
Copy link
Collaborator

tscrim commented Feb 11, 2019

Reviewer: Travis Scrimshaw

@tscrim
Copy link
Collaborator

tscrim commented Feb 11, 2019

comment:3

LGTM.

@soehms
Copy link
Member Author

soehms commented Feb 11, 2019

comment:4

Thanks!

@vbraun
Copy link
Member

vbraun commented Feb 13, 2019

Changed branch from u/soehms/permgroup_element_gap_meth to 0e444c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants