-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement Conway polynomial #27522
Comments
comment:1
still needs work New commits:
|
Branch: u/chapoton/27522 |
Commit: |
comment:2
There remains an issue about normalisation, plus more doctests needed. |
comment:3
As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9). |
Changed keywords from none to knot |
comment:5
I don't understand the line
in your code. If I uncomment it I'm getting the correct result. BTW: Wouldn't it by useful, to introduce a second option to obtain the Conway polynomial via the Homfly polynomial for cross check purpose?
Since now we have Puiseux series available the Homfly polynomial can also easily be used for cross checks with Alexander and Jones polynomials:
As soon as we have Puiseux polynomials available, an option to use it would be a nice enhancement here, too. |
Changed branch from u/chapoton/27522 to u/soehms/27522 |
Reviewer: Sebastian Oehms |
comment:7
Frederic, I still think that the line of code I posted in my previous comment (from June 2020) should be removed. After removing it the cross check against all of KnotInfo's Conway polynomials passes.
I push a corresponding fix and in addition add some doctests. If you agree with it you may give it a positive review. New commits:
|
comment:8
One small comment: -: wikipedia:`Alexander_polynomial`
+:wikipedia:`Alexander_polynomial` |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:10
Replying to @tscrim:
Fixed! |
comment:11
looks good to me. Please set to positive if you agree |
comment:12
oh, by the way please fix the syntax in the second meth role here: Sebastian Oehms (October 2020, add get_knotinfo() and meth:isisotopic |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:14
Replying to @fchapoton:
Thanks!
Done. |
Changed reviewer from Sebastian Oehms to Sebastian Oehms, Travis Scrimshaw |
Changed branch from u/soehms/27522 to |
as deduced from Alexander polynomial
CC: @tscrim @miguelmarco @slel @soehms
Component: algebraic topology
Keywords: knot
Author: Frédéric Chapoton
Branch/Commit:
bd2b791
Reviewer: Sebastian Oehms, Travis Scrimshaw
Issue created by migration from https://trac.sagemath.org/ticket/27522
The text was updated successfully, but these errors were encountered: