Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spkg-configure.m4 for ninja-build #27801

Closed
dimpase opened this issue May 8, 2019 · 8 comments
Closed

spkg-configure.m4 for ninja-build #27801

dimpase opened this issue May 8, 2019 · 8 comments
Labels
c: build: configure p: major / 3 t: enhancement
Milestone
sage-8.8

Comments

@dimpase
Copy link
Member

dimpase commented May 8, 2019

a trivial check for the version of the executable ninja.

CC: @mkoeppe @embray

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: 0b96a6e

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/27801
@dimpase dimpase added this to the sage-8.8 milestone May 8, 2019
@dimpase
Copy link
Member Author

dimpase commented May 8, 2019

Author: Dima Pasechnik

@dimpase
Copy link
Member Author

dimpase commented May 8, 2019

New commits:

0b96a6espkg-configure for ninja_build, checking for version 1.7.2 or better

@dimpase
Copy link
Member Author

dimpase commented May 8, 2019

Commit: 0b96a6e

@dimpase
Copy link
Member Author

dimpase commented May 8, 2019

Branch: u/dimpase/packages/ninja_build-config

@dimpase
Copy link
Member Author

dimpase commented May 8, 2019

comment:2

this is used to build polymake, but it's normally available on systems. The minimum version is set to match the one in stable Debian. How about Cygwin and OSX?

@mkoeppe
Copy link
Contributor

mkoeppe commented May 9, 2019

comment:3

For macOS, it's available on homebrew as package ninja.

@mkoeppe
Copy link
Contributor

mkoeppe commented May 9, 2019

Reviewer: Matthias Koeppe

@vbraun
Copy link
Member

vbraun commented May 14, 2019

Changed branch from u/dimpase/packages/ninja_build-config to 0b96a6e

@vbraun vbraun closed this as completed in 77ce161 May 14, 2019
@embray embray mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-8.8
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe