Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

polymake: Install gcc if system gcc older than 5.1 #27853

Closed
mkoeppe opened this issue May 20, 2019 · 16 comments
Closed

polymake: Install gcc if system gcc older than 5.1 #27853

mkoeppe opened this issue May 20, 2019 · 16 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented May 20, 2019

CC: @dimpase

Component: packages: experimental

Branch/Commit: u/mkoeppe/polymake__install_gcc_if_system_gcc_older_than_5_1 @ e675ad2

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/27853

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 20, 2019

comment:1

Can this be done with spkg-configure?

@dimpase
Copy link
Member

dimpase commented May 20, 2019

comment:2

Do you mean the spkg-configure of polymake?

This might be a bit tricky, I'd just implement a version check, which errors
out with a message to install a newer gcc. You if needed might tweak spkg-configure of gcc to make it easier.

As well, very old gcc's (say, 4.4) cannot even compile Sage's gcc.

Also note that clang typically fakes a gcc, sometimes (on OSX) quite old one.

@dimpase
Copy link
Member

dimpase commented May 20, 2019

comment:3

on the other hand, yes, in polymake/spkg-config.m4 you can do something like

SAGE_SPKG_CONFIGURE([gcc], [
    sage_spkg_install_polymake=yes
    AC_REQUIRE([SAGE_SPKG_CONFIGURE_GMP])
    if test $IS_REALLY_GCC = yes ; then
       AS_CASE(["$GXX_VERSION.0"],
           [[[0-4]].*|5.0.*], [
               SAGE_MUST_INSTALL_GCC([you have $CXX version $GXX_VERSION, which is too old to build polymake])
                ])
    fi

but I am not sure whether this would kick in regardless of the experimental status of polymake.

In fact I would be in favours of dropping gcc 4 support completely, and require at least 5.1 globally.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 20, 2019

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 20, 2019

comment:5

I tried this (see branch) but it seems that this script is always run, even if polymake is not requested.


New commits:

e675ad2If polymake is to be installed, install gcc if systen gcc < 5.1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 20, 2019

Commit: e675ad2

@dimpase
Copy link
Member

dimpase commented May 20, 2019

comment:6

One can have a --with-polymake=install (with default value no) switch tested in spkg-config, so that its contents is skipped, unless install is given as the value of this parameter. Except this would be a non-standard way to install a package.

[Jeez, how much I hate sage -i/-f thing... :-)]

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 20, 2019

comment:7

Replying to @dimpase:

One can have a --with-polymake=install (with default value no) switch tested in spkg-config, so that its contents is skipped, unless install is given as the value of this parameter. Except this would be a non-standard way to install a package.

Hardly an improvement.

[Jeez, how much I hate sage -i/-f thing... :-)]

Where's the ticket that will change "sage -i PACKAGE" to just reconfiguration with "--enable-PACKAGE" appended to the configure command line and "make build"?

@dimpase
Copy link
Member

dimpase commented May 20, 2019

comment:8

You can read on recent (mis)adventures in this domain on #27373, #27642...

Feel free to open such a ticket though and cc me on it.

@dimpase
Copy link
Member

dimpase commented May 20, 2019

comment:9

how about we re-target this ticket to bump up the minimal gcc version to 5.1?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 20, 2019

comment:10

Replying to @dimpase:

how about we re-target this ticket to bump up the minimal gcc version to 5.1?

It's better if that goal is not associated with an experimental package.

@embray
Copy link
Contributor

embray commented Jun 14, 2019

comment:11

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

@embray embray removed this from the sage-8.8 milestone Jun 14, 2019
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 1, 2020

comment:12

Moving some tickets to 9.2. This is not a promise that I will be working on them.

@mkoeppe mkoeppe added this to the sage-9.2 milestone May 1, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 29, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:14

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe removed this from the sage-9.4 milestone Jul 14, 2021
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 27, 2022

comment:16

outdated, should close

@dimpase
Copy link
Member

dimpase commented Jul 27, 2022

Reviewer: Dima Pasechnik

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants