Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

spkg-configure.m4 for pcre should test for UTF support etc #27936

Closed
dimpase opened this issue Jun 5, 2019 · 3 comments
Closed

spkg-configure.m4 for pcre should test for UTF support etc #27936

dimpase opened this issue Jun 5, 2019 · 3 comments

Comments

@dimpase
Copy link
Member

dimpase commented Jun 5, 2019

one can build an insufficiently powerful pcre, see #27284
So we better check that it has all the goodies needed.

Component: build: configure

Issue created by migration from https://trac.sagemath.org/ticket/27936

@dimpase dimpase added this to the sage-8.8 milestone Jun 5, 2019
@embray
Copy link
Contributor

embray commented Jun 11, 2019

comment:1

It looks to me that it's sufficient to run

$ pcretest -C utf

which strangely both outputs 1 if UTF is supported, and the exit code also is 1 if supported. So pcretest both prints the results of these checks and returns them as non-POSIX exit codes.

But fine, this means we just need to

  1. Check for pcretest

  2. Run

if test `pcretest -C utf` -eq 1`; then
...

I'd say if pcretest is absent just don't assume the system lib can be used.

@embray
Copy link
Contributor

embray commented Jun 14, 2019

comment:2

As the Sage-8.8 release milestone is pending, we should delete the sage-8.8 milestone for tickets that are not actively being worked on or that still require significant work to move forward. If you feel that this ticket should be included in the next Sage release at the soonest please set its milestone to the next release milestone (sage-8.9).

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 7, 2024

Outdated, package pcre was removed

@mkoeppe mkoeppe closed this as completed Apr 7, 2024
@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants