Downgrade rubiks to optional

[isuruf]

See discussion in https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/sage-devel/lc-HqYCFrDw/r4TlV6qCBAAJ

CC: @timokau @jhpalmieri

Component: packages: standard

Author: Frédéric Chapoton, John Palmieri

Branch/Commit: a8ea381

Reviewer: Dima Pasechnik, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/28022

[fchapoton]

Branch: public/ticket/28022

[fchapoton]

Commit: 0da2479

[fchapoton]

comment:1

here is first tentative

---

New commits:

0da2479

trac 28022 downgrade rubiks to optional

[dimpase]

comment:3

this also needs an update of http://wrongway.org/?rubiksource in rubiks.py, as it's not working any more (domain is up for sale).

e.g. we can link to https://web.archive.org/web/20121212175710/http://www.wrongway.org/?rubiksource

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

9a9087a

trac 28022 change dead url to web archive version

[sagetrac-git]

Changed commit from 0da2479 to 9a9087a

[fchapoton]

comment:5

done

[embray]

comment:6

+1 Would it make sense to use sage.features for this?

[jdemeyer]

comment:7

If we're not changing the package, there is no need to edit build/pkgs/rubiks/package-version.txt

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

fbc54a1

trac 28022 downgrade rubiks to optional

[sagetrac-git]

Changed commit from 9a9087a to fbc54a1

[fchapoton]

comment:9

version bump was undone, and then the branch squashed

[dimpase]

comment:10

OK, don't forget the author's name.

[dimpase]

Reviewer: Dima Pasechnik

[fchapoton]

Author: Frédéric Chapoton

[fchapoton]

comment:11

thx

[dimpase]

comment:12

We forgot src/sage/groups/perm_gps/cubegroup.py, where rubiks is used unconditionally.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

5f27079	trac 28022 downgrade rubiks to optional
1ecfad6	trac 28022 adding more optional rubiks tags

[sagetrac-git]

Changed commit from fbc54a1 to 1ecfad6

[fchapoton]

comment:14

indeed. Here is a fix.

[fchapoton]

comment:16

ok.. Then I have no idea what to do. If you know how to fix that, please do..

[dimpase]

comment:17

How about simply calling is_package_installed('rubiks') ?

sage: is_package_installed('rubiks')
False

[timokau]

comment:18

Note that is_package_installed is supposed to be deprecated: #20382, mostly (I think) because it is a pain for packagers.

[dimpase]

comment:19

Features entails creating sage/features/rubiks.py with some runtime tests... looks a bit insane, but OK...

[jhpalmieri]

comment:20

According to the file manifest, the rubiks package only installs six binaries, and it shouldn't be too bad to check that they exist and work, for the Features test. You could model it on sage/features/graphviz.py, for example.

[embray]

comment:21

+1 to adding it to sage.features. This is what I suggested in the first place :)

[fchapoton]

comment:22

I will not be the one that does that.

[embray]

comment:23

Ticket retargeted after milestone closed

[mkoeppe]

comment:24

Batch modifying tickets that will likely not be ready for 9.1, based on a review of the ticket title, branch/review status, and last modification date.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a8ea381

trac 28022: rebased Frédéric Chapoton's branch, added Features support

[sagetrac-git]

Changed commit from 1ecfad6 to a8ea381

[jhpalmieri]

comment:28

I rebased Frédéric's work, and I added a file features/rubiks.py. Please test with and without installing the rubiks package.

[jhpalmieri]

Changed author from Frédéric Chapoton to Frédéric Chapoton, John Palmieri

[mkoeppe]

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Matthias Koeppe

[mkoeppe]

comment:29

This works well.

[vbraun]

Changed branch from public/ticket/28022 to a8ea381