Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow doc to build with SAGE_PARI_CFG undefined #28341

Closed
kiwifb opened this issue Aug 11, 2019 · 15 comments
Closed

Allow doc to build with SAGE_PARI_CFG undefined #28341

kiwifb opened this issue Aug 11, 2019 · 15 comments

Comments

@kiwifb
Copy link
Member

kiwifb commented Aug 11, 2019

Follow up to #28242 which introduced SAGE_PARI_CFG in documentation build to identity whether or not pari is external.

This is inconvenient to distros and the behavior for external pari should be assumed if SAGE_PARI_CFG is undefined.

Depends on #28242

CC: @dimpase @timokau

Component: distribution

Author: François Bissey

Branch/Commit: 27f17ff

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/28341

@kiwifb kiwifb added this to the sage-8.9 milestone Aug 11, 2019
@kiwifb
Copy link
Member Author

kiwifb commented Aug 11, 2019

comment:1

Will replace os.environ['SAGE_PARI_CFG'] by os.environ.get('SAGE_PARI_CFG') in sage_setuo/docbuild/__init__.py.

@kiwifb
Copy link
Member Author

kiwifb commented Aug 11, 2019

comment:3

@dimpase just so I don't make a mistake. '' is the value you get when pari is coming from the system?

@dimpase
Copy link
Member

dimpase commented Aug 11, 2019

comment:5

using SAGE_PARI_CFG in docbuild is a hack.
One should really test whether the external pari is multithreaded, this is something that can be done, I just didn't do.

SAGE_PARI_CFG is storing the location of pari.cfg, something hard to find out, and needed to install gp2c, see https://github.com/sagemath/sagetrac-mirror/blob/46772dbb31f2be940bda299136455f495c6a21dc/build/pkgs/gp2c/spkg-configure.m4

@kiwifb
Copy link
Member Author

kiwifb commented Aug 11, 2019

comment:6

Replying to @dimpase:

using SAGE_PARI_CFG in docbuild is a hack.
One should really test whether the external pari is multithreaded, this is something that can be done, I just didn't do.

SAGE_PARI_CFG is storing the location of pari.cfg, something hard to find out, and needed to install gp2c, see https://github.com/sagemath/sagetrac-mirror/blob/46772dbb31f2be940bda299136455f495c6a21dc/build/pkgs/gp2c/spkg-configure.m4

Yes, I figured that out. On the other hand sage_setup/docbuild/__init__.py may not be the right place to check. So at the moment I just want to make sure that on distro where you don't run configure you get the same result as what you would expect if sage doesn't build pari but finds it on the system.

@dimpase
Copy link
Member

dimpase commented Aug 11, 2019

comment:7

Replying to @kiwifb:

@dimpase just so I don't make a mistake. '' is the value you get when pari is coming from the system?

This is the value I set. But you can just unconditionally switch to the appropriate docbuilder in Gentoo.

@kiwifb
Copy link
Member Author

kiwifb commented Aug 11, 2019

comment:8

Replying to @dimpase:

Replying to @kiwifb:

@dimpase just so I don't make a mistake. '' is the value you get when pari is coming from the system?

This is the value I set. But you can just unconditionally switch to the appropriate docbuilder in Gentoo.

I remarked on that in #28242. This is about having something working out of the box without extra patching or settings. Just using os.environ.get() already does enable me to build the doc without SAGE_PARI_CFG being set, which is a progress. I am testing the alternative builder now. Not that I can currently build the doc on Volker's branch because there is a label missing in the doc for manifolds from one of the tickets he is trying to merge.

@kiwifb
Copy link
Member Author

kiwifb commented Aug 12, 2019

Last 10 new commits:

b622942spkg-configure for pari_elldata
2e11aedspkg-configure's for PARI packages
183f47ccheck for PARI packages in PARI's spkg-configure
72f3c20spkg-configure for gp2c
6eac550as pari might become dummy, test with GAP
ac207d5don't export GP_DATA_DIR, remove other, unneeded GP* vars
317f090proper dependency resolution (all tests in PARI spkg-config)
2c26115docbuild workaround for external PARI
dd2b3faredirect gp errors to config.log
27f17ffAdd appropriate fallback if SAGE_PARI_CFG is missing

@kiwifb
Copy link
Member Author

kiwifb commented Aug 12, 2019

Commit: 27f17ff

@kiwifb
Copy link
Member Author

kiwifb commented Aug 12, 2019

Author: François Bissey

@kiwifb
Copy link
Member Author

kiwifb commented Aug 12, 2019

Dependencies: 28242

@kiwifb
Copy link
Member Author

kiwifb commented Aug 12, 2019

Branch: u/fbissey/pari_cfg_doc

@dimpase
Copy link
Member

dimpase commented Aug 12, 2019

Changed dependencies from 28242 to #28242

@dimpase
Copy link
Member

dimpase commented Aug 12, 2019

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Aug 12, 2019

comment:11

lgtm

@vbraun
Copy link
Member

vbraun commented Aug 13, 2019

Changed branch from u/fbissey/pari_cfg_doc to 27f17ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants