-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Three.js: Camera viewpoint for scene #28672
Comments
Changed keywords from none to threejs |
Branch: u/paulmasson/viewpoint |
Commit: |
comment:4
Jean-Philippe, this is a preliminary version of the functionality you're currently using in jmol. The menu option "Camera Info" has been changed to "Get Viewpoint". When selected it will copy a string of the form "[x,y,z] angle" to your clipboard, which you can then paste directly into the Sage command. RIght now there is no visible confirmation that the functionality is working. We could also have a pop-up alert with the same string, but I'm not particularly fond of those because they break the flow and create extra work. Try it out for a few examples and let me know if this is close to what you want. The projection in the tikz images appears to be orthogonal, so it doesn't look exactly the same to me as the web page graphic. New commits:
|
comment:5
Hi Paul, I'm currently on the road for another week. I will test this as soon as I get some time; if not then right when I get back to the office. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:7
After all of the effort it took to build 9.beta6, I've copied the same code to a new branch based on that version. Don't want to have to rebuild any previous versions at this point. Jean-Philippe, if you want to get this into Sage 9 then I need to hear from you sooner rather than later. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
Figured out a simple way to add a disappearing message. Better user experience. |
comment:10
Ticket retargeted after milestone closed |
Reviewer: Jean-Philippe Labbé |
Author: Paul Masson |
comment:11
Amazing!!!! It works perfectly in sage9.1beta2. I will be able to update the tutorial with this. The user experience will be much more simple! It's great! For the orthogonal projection: yes that's how it works... Unfortunately, perspective is not really featured in tikz AFAIK. Sorry for the delay it took... I put it in needs review for the sake of the patchbot. Once it has the green light, I believe it is good to go! |
comment:12
Jean-Philippe, the only changes in this ticket are in JavaScript, which this bot isn't testing (and it marks the template as unsafe at the start of the log). The failing tests are in parts of Sage that have nothing to do with this ticket. This needs to get in to handle #29192. Are we good to go? |
comment:13
Agreed. The failing tests are not related to this ticket. It's good to go! |
Changed branch from u/paulmasson/viewpoint to |
This ticket will replicate the behavior described in this comment
CC: @egourgoulhon @jplab
Component: graphics
Keywords: threejs
Author: Paul Masson
Branch/Commit:
8768faf
Reviewer: Jean-Philippe Labbé
Issue created by migration from https://trac.sagemath.org/ticket/28672
The text was updated successfully, but these errors were encountered: