Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug in CombinatorialPolyhedron of empty Lattice polytope #28678

Closed
kliem opened this issue Oct 30, 2019 · 6 comments
Closed

Bug in CombinatorialPolyhedron of empty Lattice polytope #28678

kliem opened this issue Oct 30, 2019 · 6 comments
Labels
c: geometry p: major / 3 t: bug
Milestone
sage-9.0

Comments

@kliem
Copy link
Contributor

kliem commented Oct 30, 2019

Currently

sage: CombinatorialPolyhedron(LatticePolytope([], lattice=ToricLattice(3)))

results in a TypeError, as an empty list of facets is not detected as empty polyhedron.

We fix this:

sage: CombinatorialPolyhedron(LatticePolytope([], lattice=ToricLattice(3)))
A -1-dimensional combinatorial polyhedron with 0 facets

CC: @jplab @LaisRast

Component: geometry

Keywords: lattice polytopes, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: 0a2e757

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/28678
@kliem kliem added this to the sage-9.0 milestone Oct 30, 2019
@kliem
Copy link
Contributor Author

kliem commented Oct 30, 2019

Branch: u/gh-kliem/fixemptylatticepolytope

@kliem
Copy link
Contributor Author

kliem commented Oct 30, 2019

New commits:

0a2e757fix CombinatorialPolyhedron of empty lattice polytope

@kliem
Copy link
Contributor Author

kliem commented Oct 30, 2019

Commit: 0a2e757

@jplab
Copy link

jplab commented Nov 1, 2019

comment:2

Ok, sounds good.

@jplab
Copy link

jplab commented Nov 1, 2019

Reviewer: Jean-Philippe Labbé

@vbraun
Copy link
Member

vbraun commented Nov 7, 2019

Changed branch from u/gh-kliem/fixemptylatticepolytope to 0a2e757

@vbraun vbraun closed this as completed in 43a7788 Nov 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: geometry p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.0
Development

No branches or pull requests
3 participants
@vbraun @jplab @kliem