CombinatorialPolyhedron: Remove empty folder

[kliem]

In the folder src/sage/geometry/polyhedron/combinatorial_polyhedron there is an empty folder that keeps appearing.

This is because bit_vector_operations was not properly defined in module_list.py.

We fix this by including the functions needed directly in each file with cdef extern from "bit_vector_operations.cc" and removing the module sage/geometry/polyhedron/combinatorial_polyhedron/bit_vector_operations.cc.

CC: @jplab @LaisRast

Component: geometry

Keywords: combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: c698941

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/28757

[kliem]

New commits:

3cf386c

stop empty folder from appearing

[kliem]

Branch: public/28757

[kliem]

Commit: 3cf386c

[embray]

comment:2

Ticket retargeted after milestone closed

[kliem]

comment:3

This is a new approach. I remove the module bit_vector_operations completely. Instead each file just includes whatever it needs from bit_vector_operations.cc.

---

New commits:

ae89a8b

remove empty folder in combinatorial polyhedron

[kliem]

Changed commit from 3cf386c to ae89a8b

[kliem]

Changed branch from public/28757 to public/28757-new

[kliem]

comment:4

Apply failed.

[kliem]

New commits:

a584181

remove empty folder in combinatorial polyhedron

[kliem]

Changed branch from public/28757-new to public/28757-reb

[kliem]

Changed commit from ae89a8b to a584181

[jplab]

comment:6

Seems still to cause a merge conflict...

[kliem]

comment:7

Not still. Again. The annoying thing about this approach is that I'm very likely to conflict.

[kliem]

Changed commit from a584181 to c698941

[kliem]

New commits:

c698941

remove empty folder in combinatorial polyhedron

[kliem]

Changed branch from public/28757-reb to public/28757-reb2

[jplab]

comment:10

Could you update the description of the ticket to also mention the new functions that are added?

Somehow, this ticket does more than changing 2-3 lines... Perhaps also change the title of the ticket. This will help in the future to traceback if necessary...

[jplab]

Reviewer: Jean-Philippe Labbé

[kliem]

comment:11

There are no new functions. It's just that we know grep them directly from the .cc file:

-from .bit_vector_operations cimport intersection, bit_rep_to_coatom_rep
+
+cdef extern from "bit_vector_operations.cc":
...

[jplab]

comment:13

Got it. Thanks for clarifying... it has been a while...

[kliem]

comment:14

Thanks.

[vbraun]

Changed branch from public/28757-reb2 to c698941