Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/setup.py: Replace use of is_package_installed_and_updated by sage_conf or features #28815

Closed
mkoeppe opened this issue Nov 28, 2019 · 11 comments
Closed

src/setup.py: Replace use of is_package_installed_and_updated by sage_conf or features #28815

mkoeppe opened this issue Nov 28, 2019 · 11 comments
Labels
c: build p: major / 3 t: enhancement

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 28, 2019

Currently (after #29701), src/setup.py determines what "distributions" to build using is_package_installed_and_updated, which inspects the installation records found in $SAGE_SPKG_INST = $SAGE_LOCAL/var/lib/sage/installed and also the information in $SAGE_PKGS = $SAGE_ROOT/build/pkgs.

Instead, we make it configurable via sage_conf, falling back to testing features.

(Note that after #30779, src/setup.py is intended to be invoked by the user for user-defined venvs, and is separate from build/pkgs/sagelib/setup.py, which is used by the Sage distribution.)

Alternative approach:

Depends on #30779

CC: @jdemeyer @antonio-rojas @kiwifb @dimpase @embray @timokau @isuruf @jhpalmieri

Component: build

Keywords: sd111

Issue created by migration from https://trac.sagemath.org/ticket/28815
@mkoeppe mkoeppe added this to the sage-9.0 milestone Nov 28, 2019
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 28, 2019

Dependencies: #25828

@embray
Copy link
Contributor

embray commented Jan 6, 2020

comment:2

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-9.0, sage-9.1 Jan 6, 2020
@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 9, 2020
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented May 17, 2020

Changed dependencies from #25828 to none

@mkoeppe mkoeppe changed the title Don't pass SAGE_PKGS to src/setup.py. Replace OptionalExtension(...., package=....) by condition=Feature.is_present(), Meta-ticket: Don't pass SAGE_PKGS to src/setup.py. Replace OptionalExtension(...., package=....) by condition=Feature.is_present(), May 17, 2020
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Sep 5, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 31, 2020

Dependencies: #30779

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe mkoeppe changed the title Meta-ticket: Don't pass SAGE_PKGS to src/setup.py. Replace OptionalExtension(...., package=....) by condition=Feature.is_present(), src/setup.py: Replace use of is_package_installed_and_updated by sage_conf or features Oct 31, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

comment:10

Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

Changed keywords from none to sd111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:11

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 1, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@timokau timokau mentioned this issue Nov 8, 2020
Closed
@tobiasdiez tobiasdiez mentioned this issue Jan 31, 2022
Closed
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 23, 2024 •
edited
Loading

Closing. We'll replace it by building and installing the packages sagemath-bliss, .... etc. instead.
That's #37857.

@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Apr 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@embray @mkoeppe