-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare setting up polyhedron from both Vrep and Hrep for different backends #28880
Milestone
Comments
Commit: |
Branch: public/28880 |
New commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:3
Ticket retargeted after milestone closed |
Changed branch from public/28880 to public/28880-reb |
comment:5
Looks good to me! Thanks. Sorry for the wait... |
Reviewer: Jean-Philippe Labbé |
Changed branch from public/28880-reb to |
This was referenced Mar 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#22701 implemented setting up a polyhedron from both Vrep and Hrep for the backend field.
There are plans to allow the same for polymake #26368 and with #28639 at hand we can do the same for normaliz.
So it makes sense to set up a general framework for initializing from Vrep and Hrep. This ticket does this (or rather moves what was done in #22701 accordingly).
If a backend implements the method
_init_from_Vrepresentation_and_Hrepresentation
, then the initialization ofPolyhedron_base
may use it ifVrep_minimal
andHrep_minimal
is both set to true.This option will not be exposed in the function
Polyhedron
, as a user should really know what they are doing.Also the method
_element_constructor_polyhedron
ofPolyhedra_base
sets up the new polyhedron from both representations, ifself.Element
has the method_init_from_Vrepresentation_and_Hrepresentation
.CC: @jplab @LaisRast
Component: geometry
Keywords: polytopes, backend, Vrep, Hrep, initialization
Author: Jonathan Kliem
Branch/Commit:
561a629
Reviewer: Jean-Philippe Labbé
Issue created by migration from https://trac.sagemath.org/ticket/28880
The text was updated successfully, but these errors were encountered: