Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare setting up polyhedron from both Vrep and Hrep for different backends #28880

Closed
kliem opened this issue Dec 13, 2019 · 12 comments
Closed

Comments

@kliem
Copy link
Contributor

kliem commented Dec 13, 2019

#22701 implemented setting up a polyhedron from both Vrep and Hrep for the backend field.

There are plans to allow the same for polymake #26368 and with #28639 at hand we can do the same for normaliz.

So it makes sense to set up a general framework for initializing from Vrep and Hrep. This ticket does this (or rather moves what was done in #22701 accordingly).

If a backend implements the method _init_from_Vrepresentation_and_Hrepresentation, then the initialization of Polyhedron_base may use it if Vrep_minimal and Hrep_minimal is both set to true.

This option will not be exposed in the function Polyhedron, as a user should really know what they are doing.

Also the method _element_constructor_polyhedron of Polyhedra_base sets up the new polyhedron from both representations, if self.Element has the method _init_from_Vrepresentation_and_Hrepresentation.

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, backend, Vrep, Hrep, initialization

Author: Jonathan Kliem

Branch/Commit: 561a629

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/28880

@kliem kliem added this to the sage-9.0 milestone Dec 13, 2019
@kliem
Copy link
Contributor Author

kliem commented Dec 13, 2019

Commit: ffcc0bd

@kliem
Copy link
Contributor Author

kliem commented Dec 13, 2019

Branch: public/28880

@kliem
Copy link
Contributor Author

kliem commented Dec 13, 2019

New commits:

ffcc0bdprepare setting up from both Vrep and Hrep in general

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 13, 2019

Changed commit from ffcc0bd to 2c9321e

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 13, 2019

Branch pushed to git repo; I updated commit sha1. New commits:

2c9321eremoved unused import

@embray
Copy link
Contributor

embray commented Jan 6, 2020

comment:3

Ticket retargeted after milestone closed

@embray embray modified the milestones: sage-9.0, sage-9.1 Jan 6, 2020
@kliem
Copy link
Contributor Author

kliem commented Jan 14, 2020

New commits:

cb91aa5prepare setting up from both Vrep and Hrep in general
cc8765aremoved unused import
561a629fixed pyflakes warning

@kliem
Copy link
Contributor Author

kliem commented Jan 14, 2020

Changed commit from 2c9321e to 561a629

@kliem
Copy link
Contributor Author

kliem commented Jan 14, 2020

Changed branch from public/28880 to public/28880-reb

@jplab
Copy link

jplab commented Feb 4, 2020

comment:5

Looks good to me! Thanks.

Sorry for the wait...

@jplab
Copy link

jplab commented Feb 4, 2020

Reviewer: Jean-Philippe Labbé

@vbraun
Copy link
Member

vbraun commented Feb 10, 2020

Changed branch from public/28880-reb to 561a629

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants