Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spkg-configure for tachyon #28919

Closed
dimpase opened this issue Dec 28, 2019 · 7 comments
Closed

spkg-configure for tachyon #28919

dimpase opened this issue Dec 28, 2019 · 7 comments
Labels
c: build: configure p: major / 3 t: enhancement
Milestone
sage-9.1

Comments

@dimpase
Copy link
Member

dimpase commented Dec 28, 2019

as we only need exacutables, this is trivial

CC: @kiwifb @embray @tobihan @infinity0 @isuruf @mkoeppe

Component: build: configure

Author: Dima Pasechnik

Branch/Commit: d065952

Reviewer: Isuru Fernando

Issue created by migration from https://trac.sagemath.org/ticket/28919
@dimpase dimpase added this to the sage-9.0 milestone Dec 28, 2019
@dimpase dimpase modified the milestones: sage-9.0, sage-9.1 Dec 31, 2019
@isuruf
Copy link
Member

isuruf commented Dec 31, 2019

comment:3

Since it's the executables, do we need, SAGE_SPKG_DEPCHECK([libpng]?

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 31, 2019

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

d065952spkg-configure for tachyon

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 31, 2019

Changed commit from 2b9a898 to d065952

@dimpase
Copy link
Member Author

dimpase commented Dec 31, 2019

comment:5

Replying to @isuruf:

Since it's the executables, do we need, SAGE_SPKG_DEPCHECK([libpng]?

indeed, it's not needed, removed.

@isuruf
Copy link
Member

isuruf commented Dec 31, 2019

Reviewer: Isuru Fernando

@isuruf
Copy link
Member

isuruf commented Dec 31, 2019

comment:6

There's no version check here, but sage is packaging 0.98.9 which is from 2010, so I think there's no need to check version.

@vbraun
Copy link
Member

vbraun commented Jan 5, 2020

Changed branch from u/dimpase/packages/tachyonconf to d065952

@vbraun vbraun closed this as completed in 16052a5 Jan 5, 2020
@embray embray mentioned this issue Jan 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @dimpase @isuruf