Create build/bin/sage-build-env-config and call it from build/make/deps; add sage --buildsh #29052

mkoeppe · 2020-01-20T14:49:59Z

This is part of #21707 - "Split sage-env into 5".

We set up a new configure-generated, to-be-sourced shell script build/bin/sage-build-env-config to which we move environment variable settings from src/bin/sage-env[-config] that are only needed for:

Sage-the-distribution while building spkgs,
Sage-the-distribution for building sagelib.

The new script is used in addition to src/bin/sage-env in these two contexts.

We add a command sage --buildsh, like sage --sh but using the larger environment.

Follow-up:

build/make/install contains more environment settings that should be reviewed for moving to sage-build-env-config

Depends on #29233

CC: @dimpase @embray @jdemeyer @kiwifb @isuruf

Component: build

Author: Matthias Koeppe

Branch/Commit: 2ab9b09

Reviewer: Dima Pasechnik, Volker Braun

Issue created by migration from https://trac.sagemath.org/ticket/29052

The text was updated successfully, but these errors were encountered:

mkoeppe · 2020-01-20T17:14:53Z

Branch: u/mkoeppe/create_build_bin_sage_build_env_and_call_it_from_build_make_deps__add_sage___buildsh

sagetrac-git · 2020-01-20T17:26:19Z

Commit: e3e5a08

sagetrac-git · 2020-01-20T17:26:19Z

Branch pushed to git repo; I updated commit sha1. New commits:

`e3e5a08`	`build/make/deps, build/make.Makefile.in: Source build/bin/sage-build-env-config for building sagelib and for script packages`

mkoeppe · 2020-01-20T17:27:23Z

comment:6

Updated the branch that was on #21707.

jhpalmieri · 2020-01-21T18:10:56Z

comment:8

You need to document sage --buildsh: at the top of src/bin/sage, in src/doc/en/reference/repl/options.rst, maybe in src/doc/en/installation/source.rst, maybe in the developer's guide.

mkoeppe · 2020-01-21T18:47:42Z

comment:9

Thanks! Will do.

sagetrac-git · 2020-01-21T19:49:31Z

Changed commit from e3e5a08 to 4a96e26

sagetrac-git · 2020-01-21T19:49:31Z

Branch pushed to git repo; I updated commit sha1. New commits:

`7ea77bb`	`Document 'sage -buildsh' in the output of 'sage -advanced'`
`4a96e26`	`src/doc/en/reference/repl/options.rst: Document sage --buildsh`

sagetrac-git · 2020-01-22T22:57:44Z

Changed commit from 4a96e26 to 80c6bfd

sagetrac-git · 2020-01-22T22:57:44Z

Branch pushed to git repo; I updated commit sha1. New commits:

`80c6bfd`	`Merge tag '9.1.beta1' into t/29052/create_build_bin_sage_build_env_and_call_it_from_build_make_deps__add_sage___buildsh`

mkoeppe · 2020-01-22T23:04:29Z

comment:12

Merged, ready for review

sagetrac-git · 2020-02-06T20:38:16Z

Changed commit from 80c6bfd to ecb6a8b

sagetrac-git · 2020-02-06T20:38:16Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`5244060`	`Split out build/bin/sage-build-env-config from sage-env-config`
`96b6c58`	`src/bin/sage: Add -buildsh`
`3491a9d`	`build/make/deps, build/make.Makefile.in: Source build/bin/sage-build-env-config for building sagelib and for script packages`
`11f6797`	`Document 'sage -buildsh' in the output of 'sage -advanced'`
`ecb6a8b`	`src/doc/en/reference/repl/options.rst: Document sage --buildsh`

mkoeppe · 2020-02-06T20:38:36Z

comment:14

Rebased on 9.1.beta3, needs review

dimpase · 2020-02-13T17:41:58Z

comment:16

some places say -buildsh, some say --build-sh, some say --buildsh

what's the correct one?

sagetrac-git · 2020-02-14T03:00:16Z

Changed commit from ecb6a8b to a0c3c59

sagetrac-git · 2020-02-14T03:00:16Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a0c3c59`	`Fix "--build-sh" -> "--buildsh" in a comment`

mkoeppe · 2020-02-14T03:00:54Z

comment:18

Both -buildsh and --buildsh work.

sagetrac-git · 2020-02-16T18:16:08Z

Branch pushed to git repo; I updated commit sha1. New commits:

`c1f0e62`	`Merge tag '9.1.beta4' into t/29052/create_build_bin_sage_build_env_and_call_it_from_build_make_deps__add_sage___buildsh`

sagetrac-git · 2020-02-16T18:16:08Z

Changed commit from a0c3c59 to c1f0e62

mkoeppe · 2020-02-21T18:44:17Z

comment:20

Patchbot errors on helmholtz are due to bootstrap prerequisites missing on that host.

Needs review...

sagetrac-git · 2020-02-22T22:53:38Z

Branch pushed to git repo; I updated commit sha1. New commits:

`0dc97db`	`Clean src/doc/en/installation/*.txt in bootstrap-clean, not misc-clean`
`8bd4f53`	`Merge branch 't/29233/bootstrap____make_distclean_broken' into t/29052/create_build_bin_sage_build_env_and_call_it_from_build_make_deps__add_sage___buildsh`

sagetrac-git · 2020-02-22T22:53:38Z

Changed commit from c1f0e62 to 8bd4f53

mkoeppe · 2020-02-22T22:54:11Z

Dependencies: #29233

dimpase · 2020-02-24T05:24:28Z

comment:23

ok

dimpase · 2020-02-24T05:24:28Z

Reviewer: Dima Pasechnik

mkoeppe · 2020-02-24T07:31:43Z

comment:24

Thank you!

vbraun · 2020-02-25T23:23:10Z

comment:25

[dochtml] Error building the documentation.
[dochtml] Traceback (most recent call last):
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main
[dochtml]     "__main__", mod_spec)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/runpy.py", line 85, in _run_code
[dochtml]     exec(code, run_globals)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__main__.py", line 2, in <module>
[dochtml]     main()
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 1720, in main
[dochtml]     builder()
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 327, in _wrapper
[dochtml]     getattr(get_builder(document), 'inventory')(*args, **kwds)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 552, in _wrapper
[dochtml]     self._build_everything_except_bibliography(lang, format, *args, **kwds)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 538, in _build_everything_except_bibliography
[dochtml]     build_many(build_ref_doc, non_references)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/__init__.py", line 280, in build_many
[dochtml]     _build_many(target, args, processes=NUM_THREADS)
[dochtml]   File "/home/buildbot/slave/sage_git/build/local/lib/python3.7/site-packages/sage_setup/docbuild/utils.py", line 283, in build_many
[dochtml]     raise worker_exc.original_exception
[dochtml] pkgconfig.pkgconfig.PackageNotFoundError: cblas not found not found

dimpase · 2020-02-26T08:15:11Z

comment:26

was it a build from scratch, or an incremental one?

vbraun · 2020-02-26T20:37:50Z

comment:27

Both incremental and after "make distclean"

sagetrac-git · 2020-02-27T03:37:20Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2ab9b09`	`Move SAGE_PKG_CONFIG_PATH, SAGE_NAUTY_BINS_PREFIX back to src/bin/sage-env-config.in`

sagetrac-git · 2020-02-27T03:37:20Z

Changed commit from 8bd4f53 to 2ab9b09

mkoeppe · 2020-02-27T03:38:12Z

comment:29

Thanks for catching this.

dimpase · 2020-02-27T21:07:43Z

Changed reviewer from Dima Pasechnik to Dima Pasechnik, Volker Braun

dimpase · 2020-02-27T21:07:43Z

comment:30

OK, it works now. The previous iteration somehow built, but didn't work, as it turned out, sorry.

vbraun · 2020-02-29T09:08:49Z

Changed branch from u/mkoeppe/create_build_bin_sage_build_env_and_call_it_from_build_make_deps__add_sage___buildsh to 2ab9b09

mkoeppe added this to the sage-9.1 milestone Jan 20, 2020

mkoeppe added c: build labels Jan 20, 2020

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Create build/bin/sage-build-env and call it from build/make/deps; add sage --buildsh~~ Create build/bin/sage-build-env-config and call it from build/make/deps; add sage --buildsh Jan 20, 2020

mkoeppe added the s: needs review label Jan 20, 2020

This comment has been minimized.

Sign in to view

dimpase added s: positive review and removed s: needs review labels Feb 24, 2020

vbraun added s: needs work and removed s: positive review labels Feb 25, 2020

mkoeppe added s: needs review and removed s: needs work labels Feb 27, 2020

dimpase added s: positive review and removed s: needs review labels Feb 27, 2020

vbraun removed the s: positive review label Feb 29, 2020

vbraun closed this as completed in 610a582 Feb 29, 2020

Create build/bin/sage-build-env-config and call it from build/make/deps; add sage --buildsh #29052

Create build/bin/sage-build-env-config and call it from build/make/deps; add sage --buildsh #29052

Comments

mkoeppe commented Jan 20, 2020

This comment has been minimized.

This comment has been minimized.

mkoeppe commented Jan 20, 2020

sagetrac-git mannequin commented Jan 20, 2020

sagetrac-git mannequin commented Jan 20, 2020

mkoeppe commented Jan 20, 2020

This comment has been minimized.

jhpalmieri commented Jan 21, 2020

mkoeppe commented Jan 21, 2020

sagetrac-git mannequin commented Jan 21, 2020

sagetrac-git mannequin commented Jan 21, 2020

sagetrac-git mannequin commented Jan 22, 2020

sagetrac-git mannequin commented Jan 22, 2020

mkoeppe commented Jan 22, 2020

sagetrac-git mannequin commented Feb 6, 2020

sagetrac-git mannequin commented Feb 6, 2020

mkoeppe commented Feb 6, 2020

dimpase commented Feb 13, 2020

sagetrac-git mannequin commented Feb 14, 2020

sagetrac-git mannequin commented Feb 14, 2020

mkoeppe commented Feb 14, 2020

sagetrac-git mannequin commented Feb 16, 2020

sagetrac-git mannequin commented Feb 16, 2020

mkoeppe commented Feb 21, 2020

sagetrac-git mannequin commented Feb 22, 2020

sagetrac-git mannequin commented Feb 22, 2020

mkoeppe commented Feb 22, 2020

dimpase commented Feb 24, 2020

dimpase commented Feb 24, 2020

mkoeppe commented Feb 24, 2020

vbraun commented Feb 25, 2020

dimpase commented Feb 26, 2020

vbraun commented Feb 26, 2020

sagetrac-git mannequin commented Feb 27, 2020

sagetrac-git mannequin commented Feb 27, 2020

mkoeppe commented Feb 27, 2020

dimpase commented Feb 27, 2020

dimpase commented Feb 27, 2020

vbraun commented Feb 29, 2020