flag_f_vector for polyhedra

[kliem]

We add a method to Polyhedron_base and CombinatorialPolyhedron, which wraps flag_f_polynomial of FiniteLatticePoset so that flag_f_vector(1,3) returns the f_{1,3}.

CC: @jplab @LaisRast

Component: geometry

Keywords: polyhedra, flag-vector

Author: Jonathan Kliem, Laith Rastanawi

Branch: 075c7a8

Reviewer: Jean-Philippe Labbé

Issue created by migration from https://trac.sagemath.org/ticket/29224

[kliem]

Author: Jonathan Kliem, Laith Rastanwi

[kliem]

Branch: public/29224

[kliem]

Commit: fe7d4bb

[kliem]

New commits:

d3d4285	tempory commit
aefbc44	flag_f_vector for combinatorial polyhedron
fe7d4bb	flag-f-vector for Polyhedron_base

[jplab]

comment:2

A few things:

• In the documentation, (number of faces of each dimension) should not say the same as the f-vector but say what the flag f-vector counts.
• Remove the backticks and add dash (in combinatorial polyhedron too):

-        Return the `flag_f_vector`.
+        Return the flag f-vector.

-        For each `-1 < i_0 < \dots < i_n < d` the `flag_f_vector`
+        For each `-1 < i_0 < \dots < i_n < d` the flag f-vector

• Backticks missing here (in combinatorial polyhedron file too):

-        counts the number of flags `F_0 \subset \dots \subset F_n
+        counts the number of flags `F_0 \subset \dots \subset F_n`

• Spelling (in combinatorial polyhedron too):

-        - a dictionary, if no arguments where given
-
-        - an Integer, if arguments where given
+        - a dictionary, if no arguments were given
+
+        - an Integer, if arguments were given

[sagetrac-git]

Changed commit from fe7d4bb to 83709e2

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

83709e2

typos

[sagetrac-git]

Changed commit from 83709e2 to 075c7a8

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

075c7a8

fixed index error

[jplab]

comment:6

Thanks! It looks good to me now.

[jplab]

Reviewer: Jean-Philippe Labbé

[vbraun]

Changed branch from public/29224 to 075c7a8

[mkoeppe]

Changed commit from 075c7a8 to none

[mkoeppe]

Changed author from Jonathan Kliem, Laith Rastanwi to Jonathan Kliem, Laith Rastanawi