Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix or disable failing package testsuites (spkg-check) #29322

Open
mkoeppe opened this issue Mar 12, 2020 · 13 comments
Open

Fix or disable failing package testsuites (spkg-check) #29322

mkoeppe opened this issue Mar 12, 2020 · 13 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 12, 2020

There are many spkgs whose testsuites fail.

sage-spkg uses the following defaults:

# Since Python's self-tests seem to fail on all platforms, we disable
# its test suite by default.
if [ -z "$SAGE_CHECK_PACKAGES" ]; then
    SAGE_CHECK_PACKAGES='!python2,!python3'
fi

More should be added to adjust for expected failures.

  • pathpy -- spkg-check picks up top-level tox.ini and gets confused

See also:

CC: @dimpase @jhpalmieri

Component: build

Issue created by migration from https://trac.sagemath.org/ticket/29322

@mkoeppe mkoeppe added this to the sage-9.1 milestone Mar 12, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe changed the title Fix or disable failing package testsuites Fix or disable failing package testsuites (spkg-check) Mar 12, 2020
@jhpalmieri
Copy link
Member

@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.1, sage-9.2 Apr 18, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2020

comment:8

Let's update the default list of SAGE_CHECK_PACKAGES -- and perhaps also invent another syntax in addition to '!SPKG', perhaps '?SPKG', to indicate that this package should only be run like SAGE_CHECK=warn.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2020

comment:9

Also there are some additional packages for which it just does not make any sense to run the testsuite: curl, git, ...

@jhpalmieri
Copy link
Member

comment:10

Well, we can just disable those test suites permanently, by making their spkg-check.in a no-op. (I would prefer this to deleting spkg-check.in, in case some enterprising developer later decides to add one.)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jul 8, 2020

comment:11

Replying to @jhpalmieri:

Well, we can just disable those test suites permanently, by making their spkg-check.in a no-op. (I would prefer this to deleting spkg-check.in, in case some enterprising developer later decides to add one.)

That (+ a comment why it is disabled) sounds good.

@jhpalmieri
Copy link
Member

comment:12

See #30093.

@jhpalmieri

This comment has been minimized.

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Apr 2, 2021

comment:14

Moving this ticket to 9.4, as it seems unlikely that it will be merged in 9.3, which is in the release candidate stage

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Apr 2, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 18, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 7, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Sep 19, 2022
@mkoeppe mkoeppe removed this from the sage-9.8 milestone Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants