Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pari spkg-configure.m4 should check gphelp more carefully #29342

Closed
mkoeppe opened this issue Mar 15, 2020 · 21 comments
Closed

pari spkg-configure.m4 should check gphelp more carefully #29342

mkoeppe opened this issue Mar 15, 2020 · 21 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Mar 15, 2020

Follow-up from #29319 for fedora-31-standard (https://github.com/mkoeppe/sage/runs/509417970) and likewise on fedora-32-standard:

Installing cypari-2.1.1
    Generating PARI functions: (!_) (#_) (%) (%#) (+_) (-_) CatalanCould not find translation file, docdir='/usr/bin' at /usr/bin/gphelp line 153.
    subprocess.CalledProcessError: Command '['gphelp', '-raw', 'Catalan']' returned non-zero exit status 2.

The branch is on top of #29319.

Depends on #29319

CC: @dimpase @embray @kiwifb @isuruf @timokau @antonio-rojas @videlec

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: cdd737e

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/29342

@mkoeppe mkoeppe added this to the sage-9.1 milestone Mar 15, 2020
@mkoeppe

This comment has been minimized.

@kiwifb
Copy link
Member

kiwifb commented Mar 15, 2020

comment:2

We have to be careful. My memory tells me cypari and gphelp -raw needs the documentation installed including the raw tex files - uncompressed. In the case of Catalan a run with strace tells me gphelp opens usersch3.tex.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 15, 2020

comment:3

Looks like this error was already discussed in #28242.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 15, 2020

comment:5

The problem on Fedora is that the docs are not installed by default:

# grep tsflags /etc/dnf/dnf.conf 
tsflags=nodocs

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 15, 2020

comment:6

One needs to install using yum install pari-gp --setopt='tsflags='

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 15, 2020

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 15, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

08dc02dpari spkf-configure.m4: Check for gphelp
64a028dbuild/pkgs/pari/distros/debian.txt: Add pari-doc
d83e657build/pkgs/pari/distros/fedora.txt: Install the pari-gp documentation

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 15, 2020

Commit: d83e657

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 15, 2020

Branch pushed to git repo; I updated commit sha1. New commits:

cdd737ebuild/pkgs/pari/spkg-configure.m4: Check gphelp

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Mar 15, 2020

Changed commit from d83e657 to cdd737e

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 15, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 18, 2020

comment:12

@dimpase: This one also touches fedora - and is ready for review

@dimpase
Copy link
Member

dimpase commented Mar 18, 2020

comment:13

it should be

+'pari-gp --setopt=tsflags='

not just

+pari-gp --setopt=tsflags=

to prevent bootstrap for pulling these two things apart.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 18, 2020

comment:14

That flag applies to the whole command line.

@dimpase
Copy link
Member

dimpase commented Mar 19, 2020

Reviewer: Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Mar 19, 2020

comment:15

OK, this works, positive review.

The next obstacle on Fedora 31: there is no openblas.pc, and
so I cooked up one, put it somewhere, pointed PKG_CONFIG_PATH there,
then openblas is recognised along with R, gsl, etc, but make ends with

make[2]: Entering directory '/home/dima/sagetrac-mirror/build/make'
make[2]: *** No rule to make target '/home/dima/sagetrac-mirror/src/lib/pkgconfig/cblas.pc', needed by '/home/dima/sagetrac-mirror/local/lib/pkgconfig/cblas.pc'.  Stop.
make[2]: Leaving directory '/home/dima/sagetrac-mirror/build/make'

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 19, 2020

comment:16

Thanks!

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 19, 2020

comment:17

Replying to @dimpase:

The next obstacle on Fedora 31: there is no openblas.pc, and
so I cooked up one, put it somewhere, pointed PKG_CONFIG_PATH there,
then openblas is recognised along with R, gsl, etc, but make ends with

make[2]: Entering directory '/home/dima/sagetrac-mirror/build/make'
make[2]: *** No rule to make target '/home/dima/sagetrac-mirror/src/lib/pkgconfig/cblas.pc', needed by '/home/dima/sagetrac-mirror/local/lib/pkgconfig/cblas.pc'.  Stop.
make[2]: Leaving directory '/home/dima/sagetrac-mirror/build/make'

Yes, the pkgconfig mess needs to be cleaned up. #29082

@dimpase
Copy link
Member

dimpase commented Mar 19, 2020

comment:18

Yes, I'm on it.

@vbraun
Copy link
Member

vbraun commented Mar 25, 2020

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants