Migrate neighborly to combinatorial polyhedron

[kliem]

We migrate is_neighborly and neighborliness to CombinatorialPolyhedron.
It is also faster now, as use the f-vector instead of indirectly getting the number of k-faces.

Along the way we add is_simplex to CombinatorialPolyhedron and cache the methods f_vector and n_vertices.

CC: @jplab @LaisRast

Component: geometry

Keywords: neighborly polytopes

Author: Jonathan Kliem

Branch/Commit: aa535d8

Reviewer: Jean-Philippe Labbé, Laith Rastanawi

Issue created by migration from https://trac.sagemath.org/ticket/29565

[kliem]

Commit: 847740a

[kliem]

Branch: public/29565

[kliem]

New commits:

847740a

migrate neighborly to combinatorial polyhedron

[LaisRast]

comment:2

• I would suggest adding the definitions of "k-neighborly" and "neighborly" instead of referring to Wikipedia.

• The sentence for the d-simplex is not a definition. It is just an example. So why should it be mentioned?

-        - ``True`` if the every set of up to ``k`` vertices forms a face,
+        - ``True`` if every set of up to ``k`` vertices forms a face

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

0f74036

improvements in the documentation

[sagetrac-git]

Changed commit from 847740a to 0f74036

[kliem]

New commits:

f5caca8	migrate neighborly to combinatorial polyhedron
80ce9f9	improvements in the documentation

[kliem]

Changed branch from public/29565 to public/29565-reb

[kliem]

Changed commit from 0f74036 to 80ce9f9

[jplab]

Reviewer: Jean-Philippe Labbé

[jplab]

comment:6

Small coding style:

+    @cached_method
+    def neighborliness(self):
+        r"""
-        Returns the largest ``k``, such that the polyhedron is ``k``-neighborly.
+        Return the largest ``k``, such that the polyhedron is ``k``-neighborly.

You can put this on positive review on my behalf once this is fixed.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

aa535d8

coding style

[sagetrac-git]

Changed commit from 80ce9f9 to aa535d8

[kliem]

comment:8

Thank you.

---

New commits:

aa535d8

coding style

---

New commits:

aa535d8

coding style

[LaisRast]

Changed reviewer from Jean-Philippe Labbé to Jean-Philippe Labbé, Laith Rastanawi

[vbraun]

Changed branch from public/29565-reb to aa535d8