Sage documentation search page broken

[antonio-rojas]

Go to
https://doc.sagemath.org/html/en/reference/search.html?q=modules

and see the many [object Object] labels throughout the page.

CC: @jcamp0x2a @kwankyu @haraldschilly @slel @williamstein

Component: documentation

Keywords: online_documentation, search, js

Branch/Commit: u/klee/29576 @ 74d1330

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29576

[slel]

Changed keywords from none to online_documentation, search, js

[slel]

comment:4

Restoring the online documentation's search box
seems critical to me.

Can anyone help with that?

[kwankyu]

comment:7

Replying to @slel:

Restoring the online documentation's search box
seems critical to me.

Can anyone help with that?

What is the normal result of the search box? What should be shown? Would you explain?

[mkoeppe]

comment:8

Moving to 9.4, as 9.3 has been released.

[mkoeppe]

comment:10

Reported again in https://groups.google.com/g/sage-devel/c/FxjVDtqxw1U/m/t_K6IDjUAAAJ

[mkoeppe]

comment:11

See also: #31415

[kwankyu]

Branch: u/klee/29576

[kwankyu]

Author: Kwankyu Lee

[sagetrac-git]

Commit: 74d1330

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

74d1330

Revive search in documentation

[kwankyu]

comment:14

The patch revives search page.

For this, I had to turn off Thebe (see changes in layout.html), which seems to conflict with underline.js. Actually it seems old Thebe javascript file is to blame, as with the latest one from CDN works fine with the search page.

I am not sure if Thebe still works with Sage. See related #24593. If we cannot turn off Thebe, then please provide updated javascript (here or to #24593).

[kwankyu]

comment:16

What I did is mostly to make our customized layout.html and search.html to be close to original ones from Sphinx.

[jhpalmieri]

comment:18

See also #32854.

[slel]

comment:19

Set milestone to sage-9.6 after Sage 9.5 release.

[kwankyu]

comment:20

The code in this ticket is now merged to the branch of #33309. Hence we close this ticket.

[mkoeppe]

Changed author from Kwankyu Lee to none

[mkoeppe]

Reviewer: Matthias Koeppe