Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't test whether ppl is an installed package #29591

Closed
jhpalmieri opened this issue Apr 26, 2020 · 7 comments
Closed

Don't test whether ppl is an installed package #29591

jhpalmieri opened this issue Apr 26, 2020 · 7 comments
Labels
p: major / 3 t: bug
Milestone
sage-9.1

Comments

@jhpalmieri
Copy link
Member

sage.misc.package tests the installed version of ppl, but this fails if the system version of ppl is being used.

Also fix some other doctests in that file that depend on ordering of dictionaries, and possibly on packages which we may not install in the future.

Component: misc

Author: John Palmieri

Branch/Commit: 32ae22c

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29591
@jhpalmieri jhpalmieri added this to the sage-9.1 milestone Apr 26, 2020
@jhpalmieri
Copy link
Member Author

Branch: u/jhpalmieri/ppl-package-doctest

@jhpalmieri
Copy link
Member Author

New commits:

32ae22ctrac 29591: do not use ppl as an example installed packaged,

@jhpalmieri
Copy link
Member Author

Commit: 32ae22c

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 26, 2020

Reviewer: Matthias Koeppe

@mkoeppe
Copy link
Contributor

mkoeppe commented Apr 26, 2020

comment:3

Looks good.

@jhpalmieri
Copy link
Member Author

comment:4

Thank you. #29042 will need to be rebased, but it wasn't marked "needs review" yet.

@vbraun
Copy link
Member

vbraun commented May 2, 2020

Changed branch from u/jhpalmieri/ppl-package-doctest to 32ae22c

@vbraun vbraun closed this as completed in ee9518f May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: bug
Projects
None yet
Milestone
sage-9.1
Development

No branches or pull requests
3 participants
@vbraun @jhpalmieri @mkoeppe