-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
proper fix for "fedora-30-standard: Doctests using system brial crash" #29792
Comments
comment:2
Running tests now: cygwin-standard https://github.com/kliem/sage-test-27122/actions/runs/125137233 gcc_spkg https://github.com/kliem/sage-test-27122/actions/runs/125137236 targets optional https://github.com/kliem/sage-test-27122/actions/runs/125137239 tox.ini https://github.com/kliem/sage-test-27122/actions/runs/125137242 cygwin-minimal https://github.com/kliem/sage-test-27122/actions/runs/125137245 |
comment:3
Seems to work fine. https://github.com/kliem/sage-test-27122/actions/runs/125137242 It rejects brial on fedora 30 and 31 and ubuntu eoan (all use Brial 1.2.5). It doesn't reject Brial 1.2.4 on debian buster and Brial 1.2.7 on ubuntu focal. |
comment:4
it also accepts brial 1.2.8 on Gentoo lunux. |
comment:5
I think this is good to go. |
Reviewer: Jonathan Kliem |
Changed branch from u/dimpase/packages/brialconfigfix to |
This is a followup to #29490.
We now add code rejecting Brial 1.2.5 - provided it can
be recognised from
VERSION
macro inpolybory/config.h
header.This identifies standard Brial on Fedora 30 (and possibly elsewhere, but tough luck then).
CC: @orlitzky @mkoeppe
Component: build: configure
Author: Dima Pasechnik
Branch/Commit:
1ef1f87
Reviewer: Jonathan Kliem
Issue created by migration from https://trac.sagemath.org/ticket/29792
The text was updated successfully, but these errors were encountered: