normaliz backend isn't ready for generators

[kliem]

sage: P = polytopes.simplex(backend='normaliz')
sage: K.<sqrt2> = QuadraticField(2)
sage: P.dilation(sqrt2)
Traceback (most recent call last):
...
AttributeError: 'generator' object has no attribute 'list'

The reason for this is simple. With optimization in #29200, it seems that generators are passed down to the normaliz backend and this isn't ready for this yet (when converting the data to the normaliz field).

CC: @jplab @LaisRast

Component: geometry

Keywords: polytopes, dilation

Author: Jonathan Kliem

Branch/Commit: 21f9d90

Reviewer: Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/29836

[kliem]

comment:1

I just marked this as critical, because this is regression.

[kliem]

New commits:

cb13ddb

allow generators for Vrep/Hrep for backend normaliz

[kliem]

Commit: cb13ddb

[kliem]

Branch: public/29836

[fchapoton]

comment:3

missing the # optional tag

[fchapoton]

comment:4

and you could use

isinstance(thing, (A, B, C))

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

002e543

added optional tag; small improvement

[sagetrac-git]

Changed commit from cb13ddb to 002e543

[kliem]

comment:6

Replying to @fchapoton:

and you could use

isinstance(thing, (A, B, C))

Much better. Thanks.

[mkoeppe]

comment:7

Probably Polyhedron_base should get some _test_... methods to make sure that methods are tested with all backends instead of relying on coverage by copy-paste doctests.

[kliem]

comment:8

That would probably a good thing to do. I'm not familiar with TestSuite at all, but that should probably make things better.

[mkoeppe]

comment:9

Take a look at sage.numerical.backends.GenericBackend. Some time ago I did a similar thing for the MIP backends there. There's also LoggingBackend, which provides a semiautomatic way to make _test... methods from existing doctests.

[kliem]

comment:10

Thank you for the reference. I will do this, but better in a separate ticket.

[kliem]

comment:11

I opened #29842 for this.

[mkoeppe]

Reviewer: Matthias Koeppe

[kliem]

comment:13

Thank you.

[kiwifb]

comment:14

In

+            sage: P = polytopes.simplex(backend='normaliz')  # optional - pynormaliz
+            sage: K.<sqrt2> = QuadraticField(2)              # optional - pynormaliz
+            sage: P.dilation(sqrt2)

the last line needs to be optional as well. If you don't have pynormalize you get a nice NameError: name P is not defined message in your doctests.

[sagetrac-git]

Changed commit from 002e543 to 21f9d90

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

21f9d90

optional tag again

[kliem]

comment:16

Thanks for catching that.

[vbraun]

Changed branch from public/29836 to 21f9d90