Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move sage.structure.formal_sum to sage.modules #29870

Closed
mkoeppe opened this issue Jun 15, 2020 · 4 comments
Closed

Move sage.structure.formal_sum to sage.modules #29870

mkoeppe opened this issue Jun 15, 2020 · 4 comments
Labels
p: major / 3 t: enhancement t: refactoring

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 15, 2020

It imports Module and ModuleElement, so this is where it should go, leaving a deprecated reimport behind.

This is for #29865.

Depends on #29883

CC: @tscrim

Component: refactoring

Issue created by migration from https://trac.sagemath.org/ticket/29870
@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 15, 2020
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 18, 2020

Dependencies: #29883

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Aug 13, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:4

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Apr 30, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 27, 2023

No need any more to move it.

@mkoeppe mkoeppe closed this as not planned Won't fix, can't repro, duplicate, stale Jun 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
p: major / 3 t: enhancement t: refactoring
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mkoeppe