-
-
Notifications
You must be signed in to change notification settings - Fork 491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.categories: Replace imports from sage.rings.all by more specific imports #29881
Comments
comment:1
I have also run into import loops in a subtle way because of stuff importing from |
Commit: |
This comment has been minimized.
This comment has been minimized.
Author: Matthias Koeppe |
Changed dependencies from #29880 to none |
Reviewer: Travis Scrimshaw |
comment:7
Green patchbot => positive review. |
comment:8
bot is green |
Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Frédéric Chapoton |
comment:9
Thanks! |
Changed branch from u/mkoeppe/sage_categories__replace_imports_from_sage_rings_all_by_more_specific_imports to |
sage.rings.all
has a mixture of generic classes and implementation classes. Some of the generic and/or basic ones will probably have to be included insage-objects
(#29865). We prepare this by getting rid of imports fromsage.rings.all
throughoutsage.categories
.CC: @tscrim
Component: refactoring
Author: Matthias Koeppe
Branch/Commit:
82676e6
Reviewer: Travis Scrimshaw, Frédéric Chapoton
Issue created by migration from https://trac.sagemath.org/ticket/29881
The text was updated successfully, but these errors were encountered: