Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.structure, sage.misc: Replace import of sage.categories.all by more specific imports #29916

Closed
mkoeppe opened this issue Jun 20, 2020 · 10 comments
Closed

sage.structure, sage.misc: Replace import of sage.categories.all by more specific imports #29916

mkoeppe opened this issue Jun 20, 2020 · 10 comments
Labels
c: categories p: major / 3 t: enhancement
Milestone
sage-9.2

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Jun 20, 2020

sage.structure should only depend on basic categories such as sage.categories.morphism, sage.categories.pushout to support the parent/element framework and coercion, but not on more specialized ones such as sage.categories.modular_abelian_varieties.

This is for #29865 (sage-objects), which should pull in only a small part of sage.categories -- less than what sage.categories.basic imports.

CC: @tscrim @nthiery

Component: categories

Author: Matthias Koeppe

Branch/Commit: ce8fa70

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/29916
@mkoeppe mkoeppe added this to the sage-9.2 milestone Jun 20, 2020
@mkoeppe mkoeppe changed the title sage.structure: Replace import of sage.categories.all by more specific imports sage.structure, sage.misc: Replace import of sage.categories.all by more specific imports Jun 20, 2020
@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 20, 2020

Branch: u/mkoeppe/sage_structure__sage_misc__replace_import_of_sage_categories_all_by_more_specific_imports

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 20, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 20, 2020

New commits:

ce8fa70sage.structure, sage.misc: Replace import of sage.categories.all by more specific imports

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 20, 2020

Commit: ce8fa70

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 21, 2020

comment:5

Patchbot is green, needs review

@tscrim
Copy link
Collaborator

tscrim commented Jun 22, 2020

comment:6

LGTM.

@tscrim
Copy link
Collaborator

tscrim commented Jun 22, 2020

Reviewer: Travis Scrimshaw

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jun 22, 2020

comment:7

Thanks!

@vbraun
Copy link
Member

vbraun commented Jul 8, 2020

Changed branch from u/mkoeppe/sage_structure__sage_misc__replace_import_of_sage_categories_all_by_more_specific_imports to ce8fa70

@vbraun vbraun closed this as completed in df41dca Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: categories p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.2
Development

No branches or pull requests
3 participants
@vbraun @tscrim @mkoeppe