Upgrade: Maxima 5.44.0 #30063

pjbruin · 2020-07-04T11:18:41Z

Upstream tarball: see upstream_url in build/pkgs/maxima/checksums.ini.

Previous update: #26625 Update maxima to 5.42.2

Follow-up bug: #30389

Depends on #22191

CC: @dimpase @kiwifb @timokau @saraedum @slel @antonio-rojas @kcrisman @nbruin @paulmasson

Component: packages: standard

Keywords: upgrade, maxima

Author: Matthias Koeppe, Thierry Monteil

Branch: 21e2fea

Reviewer: Emmanuel Charpentier, Matthias Koeppe

Issue created by migration from https://trac.sagemath.org/ticket/30063

The text was updated successfully, but these errors were encountered:

mkoeppe · 2020-07-06T00:22:30Z

Dependencies: #22191

mkoeppe · 2020-07-06T00:34:51Z

Branch: u/mkoeppe/upgrade_maxima_to_5_44_0

mkoeppe · 2020-07-06T00:35:33Z

Commit: abb763e

mkoeppe · 2020-07-06T00:35:33Z

comment:3

Patches need to be removed or updated.

Last 10 new commits:

`1d074e8`	`doctest fixes`
`266d8c1`	`backport ECL PR #210`
`12447bc`	`reject old makeinfo`
`a3e0eca`	`add upstream fix from MR 215`
`89b006b`	`add the patch from upstream MR 214`
`0b77737`	`add upstream MR 216 (to fix cygwin fork)`
`8ca1c0e`	`Merge tag '9.2.beta2' into t/22191/public/packages/ecl20`
`f82c716`	`Commit 75877dd8 from upstream`
`324869a`	`Merge branch 'public/packages/ecl20' of git://trac.sagemath.org/sage into t/30063/upgrade_maxima_to_5_44_0`
`abb763e`	`build/pkgs/maxima: Update to 5.44.0`

sagetrac-git · 2020-07-19T06:04:38Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`3db87ad`	`build/pkgs/maxima: Update to 5.44.0`

sagetrac-git · 2020-07-19T06:04:38Z

Changed commit from abb763e to 3db87ad

mkoeppe · 2020-07-19T06:19:26Z

comment:8

Removing bugfix3629.patch, which is in 5.44.0

0001-taylor2-Avoid-blowing-the-stack-when-diff-expand-isn.patch does not apply. 5.44.0 has a different (simpler) change in this code.

sagetrac-git · 2020-07-19T06:21:32Z

Branch pushed to git repo; I updated commit sha1. New commits:

`bcf3c98`	`Remove old patches`

sagetrac-git · 2020-07-19T06:21:32Z

Changed commit from 3db87ad to bcf3c98

mkoeppe · 2020-07-19T06:21:51Z

comment:10

On macOS,

[maxima-5.44.0] /bin/bash /Users/mkoeppe/s/sage/sage-rebasing/worktree-algebraic-2018-spring/local/var/tmp/sage/build/maxima-5.44.0/src/missing makeinfo --html -c TEXI2HTML=1 --split=chapter --document-lang=en --output=. --css-include=../../../doc/info/manual.css --init-file  ../../../doc/info/texi2html.init  xmaxima.texi
[maxima-5.44.0] makeinfo: invalid option -- c
[maxima-5.44.0] Try `makeinfo --help' for more information.

mkoeppe · 2020-07-19T06:22:28Z

comment:11

This is /usr/bin/makeinfo

$ makeinfo --version
makeinfo (GNU texinfo) 4.8

Copyright (C) 2004 Free Software Foundation, Inc.

sagetrac-git · 2020-07-19T07:14:03Z

Changed commit from bcf3c98 to 07aa2f9

sagetrac-git · 2020-07-19T07:14:03Z

Branch pushed to git repo; I updated commit sha1. New commits:

`07aa2f9`	`build/pkgs/maxima/spkg-install.in: New workaround for makeinfo trouble`

mkoeppe · 2020-07-19T07:17:59Z

comment:13

Builds OK now on macOS. Haven't tested anything else

mkoeppe · 2020-07-19T07:24:45Z

comment:14

Tests run at https://github.com/mkoeppe/sage/actions/runs/174422230

dimpase · 2020-07-19T07:46:32Z

comment:15

Replying to @sagetrac-git:

Branch pushed to git repo; I updated commit sha1. New commits:

`07aa2f9`	`build/pkgs/maxima/spkg-install.in: New workaround for makeinfo trouble`

don't they have an option not to build docs?

mkoeppe · 2020-07-19T14:52:18Z

comment:16

Unfortunately they don't.

antonio-rojas · 2020-07-19T16:27:27Z

comment:17

These are the test failures I get downstream (using system maxima):

**********************************************************************
File "/usr/lib/python3.8/site-packages/sage/interfaces/maxima_abstract.py", line 225, in sage.interfaces.maxima_abstract.MaximaAbstract.example
Failed example:
    maxima.example('arrays')
Expected:
    a[n]:=n*a[n-1]
                                    a  := n a
                                     n       n - 1
    a[0]:1
    a[5]
                                          120
    a[n]:=n
    a[6]
                                           6
    a[4]
                                          24
                                         done
Got:
                                     n       n - 1
    a[0]:1
    a[5]
                                          120
    a[n]:=n
    a[6]
                                           6
    a[4]
                                          24
                                         done
    <BLANKLINE>
**********************************************************************
File "/usr/lib/python3.8/site-packages/sage/interfaces/maxima_abstract.py", line 283, in sage.interfaces.maxima_abstract.MaximaAbstract.completions
Failed example:
    sorted(maxima.completions('gc', verbose=False))
Expected:
    ['gcd', 'gcdex', 'gcfactor', 'gctime']
Got:
    ['gcd', 'gcd\\-impl', 'gcdex', 'gcfactor', 'gcfactor\\-impl', 'gctime']
**********************************************************************
File "/usr/lib/python3.8/site-packages/sage/symbolic/expression.pyx", line 10031, in sage.symbolic.expression.Expression.simplify_hypergeometric
Failed example:
    hypergeometric_M(1, 3, x).simplify_hypergeometric()
Expected:
    -2*(x - e^x + 1)/x^2
Got:
    2*e^x*gamma_incomplete_lower(2, x)/x^2
**********************************************************************
File "/usr/lib/python3.8/site-packages/sage/symbolic/integration/integral.py", line 864, in sage.symbolic.integration.integral.integrate
Failed example:
    a = integral(log(cot(x) - 1), x, 0, pi/4); a  # long time (about 6 s)
Expected:
    -1/4*pi*log(2) - 1/2*I*dilog(I + 1) + 1/2*I*dilog(-I + 1) + 1/2*I*dilog(1/2*I + 1/2) - 1/2*I*dilog(-1/2*I + 1/2)
Got:
    1/4*pi*(I*pi + log(2)) - 1/2*pi*log(2) - 1/2*I*dilog(I + 1) + 1/2*I*dilog(-I + 1) + 1/2*I*dilog(1/2*I + 1/2) - 1/2*I*dilog(-1/2*I + 1/2)
**********************************************************************
File "/usr/lib/python3.8/site-packages/sage/symbolic/integration/integral.py", line 866, in sage.symbolic.integration.integral.integrate
Failed example:
    abs(N(a - pi*log(2)/8)) < 1e-15  # long time
Expected:
    True
Got:
    False
**********************************************************************

The first one needs a readjustment of the number of removed lines in https://github.com/sagemath/sagetrac-mirror/blob/develop/src/sage/interfaces/maxima_abstract.py#n183

The ones in integration/integral.py are a known upstream issue since 5.43. The corresponding tests in maxima are disabled as known to fail, so maybe they can be tagged as known bug here.

The other two seem harmless.

sagetrac-git · 2020-07-20T03:27:33Z

Changed commit from 07aa2f9 to 046634d

sagetrac-git · 2020-07-20T03:27:33Z

Branch pushed to git repo; I updated commit sha1. New commits:

`046634d`	`sage.interfaces.maxima_abstract.MaximaAbstract._command_runner: Skip all comment lines, rather than counting lines to skip`

mkoeppe · 2020-07-20T03:28:38Z

comment:19

Replying to @antonio-rojas:

The first one needs a readjustment of the number of removed lines in https://github.com/sagemath/sagetrac-mirror/blob/develop/src/sage/interfaces/maxima_abstract.py#n183

I have fixed the first one by a method that I hope to be more robust.

mkoeppe · 2020-07-20T04:06:39Z

comment:20

Replying to @antonio-rojas:

These are the test failures I get downstream (using system maxima):

**********************************************************************
File "/usr/lib/python3.8/site-packages/sage/interfaces/maxima_abstract.py", line 283, in sage.interfaces.maxima_abstract.MaximaAbstract.completions
Failed example:
    sorted(maxima.completions('gc', verbose=False))
Expected:
    ['gcd', 'gcdex', 'gcfactor', 'gctime']
Got:
    ['gcd', 'gcd\\-impl', 'gcdex', 'gcfactor', 'gcfactor\\-impl', 'gctime']
**********************************************************************

This is now https://sourceforge.net/p/maxima/bugs/3643/

sagetrac-git · 2020-07-20T04:09:33Z

Changed commit from 046634d to d1ad8d7

sagetrac-git · 2020-07-20T04:09:33Z

Branch pushed to git repo; I updated commit sha1. New commits:

`d1ad8d7`	`sage.interfaces.maxima_abstract.MaximaAbstract.completions: Remove '-impl' functions`

EmmanuelCharpentier · 2020-08-14T15:28:52Z

Reviewer: Emmanuel Charpentier

EmmanuelCharpentier · 2020-08-14T15:28:52Z

comment:44

Adding my name (as I should have initially...), but keeping it at needs_review.

EmmanuelCharpentier · 2020-08-14T15:31:41Z

comment:45

Replying to @mkoeppe:

Also, this ticket should undergo portability testing before it should be set to "positive review".

I agree. But trac lacks a state of tentative_positive_review, which should be useful in similar situations (i. e. code changes with (known|potential) platform issues...).

EmmanuelCharpentier · 2020-08-14T15:33:33Z

comment:46

Replying to @seblabbe:

Reviewer name is missing, I am changing to needs work before the release manager needs to do it.

Damn ! I keep forgetting this. Old age ? Incipient Alzheimer's ?

Done, anyway.

mkoeppe · 2020-08-14T15:45:19Z

Changed reviewer from Emmanuel Charpentier to Emmanuel Charpentier, github.com/mkoeppe/sage/actions/runs/208788708, github.com/mkoeppe/sage/actions/runs/208788707

mkoeppe · 2020-08-15T00:31:09Z

comment:48

All clean on debian and ubuntu, waiting for more results

pjbruin · 2020-08-15T06:41:59Z

comment:49

Replying to @sagetrac-tmonteil:

I was working on upgrading Maxima too (as i did not see that ticket), so while i am not a symbolics expert, i fixed the gamma_incomplete_lower issue: that function was called gamma_greek by Maxima before.

Nice solution!

I also marked the intergration regression as known bug.

Would it be worth finding out when this regression was introduced in Maxima and try to add a patch to fix it?

dimpase · 2020-08-15T07:00:15Z

comment:50

Replying to @mkoeppe:

Replying to @EmmanuelCharpentier:

./configure should :

suggest the installation of the relevant packages for older versions (recompiling the gcc smalah takes a geological age or two...), and

suggest reconfiguring with the relevant arguments.

Where should this ... be usefully posted ?

Try #29586 (Improve configure's recommendations). It would be helpful to include the messages that configure prints on your system, and to explain what is missing.

I would change the default ./configure outcomes of not finding gcc, gfortran, gmp, etc to Error.
(which can be overridden by specifying explicit options)

sagetrac-tmonteil · 2020-08-19T11:58:13Z

comment:51

Replying to @pjbruin:

Replying to @sagetrac-tmonteil:

I was working on upgrading Maxima too (as i did not see that ticket), so while i am not a symbolics expert, i fixed the gamma_incomplete_lower issue: that function was called gamma_greek by Maxima before.

Nice solution!

I also marked the intergration regression as known bug.

Would it be worth finding out when this regression was introduced in Maxima and try to add a patch to fix it?

It goes far beyond my skills, as i never wrote a single line of lisp.

The best i can do is to report the regression upstream and follow its evolution to untag the corresponding doctest once it is fixed. I am not sure this regression should prevent us to update Maxima.

kcrisman · 2020-08-19T12:10:46Z

comment:52

The best i can do is to report the regression upstream and follow its evolution to untag the corresponding doctest once it is fixed. I am not sure this regression should prevent us to update Maxima.

You can also open a new ticket for tracking that upstream report so we don't lose it (as opposed to only noticing the doctest change if Maxima fixes this, if anyone even tests the "known bug" doctests much). I agree that if there is significant improvement introduced, then in practice we have often upgraded on a utilitarian view of things.

sagetrac-tmonteil · 2020-08-19T12:32:51Z

comment:53

Replying to @kcrisman:

The best i can do is to report the regression upstream and follow its evolution to untag the corresponding doctest once it is fixed. I am not sure this regression should prevent us to update Maxima.

You can also open a new ticket for tracking that upstream report so we don't lose it (as opposed to only noticing the doctest change if Maxima fixes this, if anyone even tests the "known bug" doctests much). I agree that if there is significant improvement introduced, then in practice we have often upgraded on a utilitarian view of things.

Follow-up for tracking this issue: #30389

EmmanuelCharpentier · 2020-08-19T12:40:23Z

comment:54

Replying to @kcrisman:

The best i can do is to report the regression upstream and follow its evolution to untag the corresponding doctest once it is fixed. I am not sure this regression should prevent us to update Maxima.

You can also open a new ticket for tracking that upstream report so we don't lose it (as opposed to only noticing the doctest change if Maxima fixes this, if anyone even tests the "known bug" doctests much). I agree that if there is significant improvement introduced, then in practice we have often upgraded on a utilitarian view of things.

Possibly related : #30379 and the fossil tickets mentioned therein...

EmmanuelCharpentier · 2020-08-19T13:59:21Z

comment:55

Replying to @mkoeppe:

All clean on debian and ubuntu, waiting for more results

FWIW, worked again in upgrading to 9.2.beta9.

mkoeppe · 2020-08-19T17:35:16Z

Changed reviewer from Emmanuel Charpentier, github.com/mkoeppe/sage/actions/runs/208788708, github.com/mkoeppe/sage/actions/runs/208788707 to Emmanuel Charpentier, Matthias Koeppe

slel · 2020-08-19T23:10:15Z

Changed keywords from none to upgrade, maxima

vbraun · 2020-08-20T22:22:49Z

Changed branch from u/tmonteil/upgrade_maxima_to_5_44_0 to 21e2fea

sagetrac-tmonteil · 2020-08-24T10:21:13Z

Changed commit from 21e2fea to none

pjbruin added this to the sage-9.2 milestone Jul 4, 2020

pjbruin added c: packages: standard labels Jul 4, 2020

This comment has been minimized.

Sign in to view

mkoeppe added the s: needs review label Aug 14, 2020

mkoeppe added s: positive review and removed s: needs review labels Aug 19, 2020

This comment has been minimized.

Sign in to view

slel changed the title ~~Upgrade Maxima to 5.44.0~~ Upgrade: Maxima 5.44.0 Aug 19, 2020

vbraun removed the s: positive review label Aug 20, 2020

vbraun closed this as completed in 611a2d6 Aug 20, 2020

This comment has been minimized.

Sign in to view

This was referenced Sep 1, 2020

Segfault for boolean evaluation of expression with assumptions #28538

Closed

Stack overflow during symbolic manipulations #30353

Closed

Wrong integrate(log(cot(x)-1),x,0,pi/4) (regression) #30389

Open

jhpalmieri mentioned this issue Nov 7, 2020

Homebrew: add $HOMEBREWPREFIX/opt/texinfo/bin to PATH #30792

Closed

antonio-rojas mentioned this issue Jun 21, 2021

Update maxima to 5.45.0 #31876

Closed

Upgrade: Maxima 5.44.0 #30063

Upgrade: Maxima 5.44.0 #30063

Comments

pjbruin commented Jul 4, 2020

mkoeppe commented Jul 6, 2020

mkoeppe commented Jul 6, 2020

mkoeppe commented Jul 6, 2020

mkoeppe commented Jul 6, 2020

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

sagetrac-git mannequin commented Jul 19, 2020

sagetrac-git mannequin commented Jul 19, 2020

mkoeppe commented Jul 19, 2020

sagetrac-git mannequin commented Jul 19, 2020

sagetrac-git mannequin commented Jul 19, 2020

mkoeppe commented Jul 19, 2020

mkoeppe commented Jul 19, 2020

sagetrac-git mannequin commented Jul 19, 2020

sagetrac-git mannequin commented Jul 19, 2020

mkoeppe commented Jul 19, 2020

mkoeppe commented Jul 19, 2020

dimpase commented Jul 19, 2020

mkoeppe commented Jul 19, 2020

antonio-rojas commented Jul 19, 2020

sagetrac-git mannequin commented Jul 20, 2020

sagetrac-git mannequin commented Jul 20, 2020

mkoeppe commented Jul 20, 2020

mkoeppe commented Jul 20, 2020

sagetrac-git mannequin commented Jul 20, 2020

sagetrac-git mannequin commented Jul 20, 2020

EmmanuelCharpentier mannequin commented Aug 14, 2020

EmmanuelCharpentier mannequin commented Aug 14, 2020

EmmanuelCharpentier mannequin commented Aug 14, 2020

EmmanuelCharpentier mannequin commented Aug 14, 2020

mkoeppe commented Aug 14, 2020

mkoeppe commented Aug 15, 2020

pjbruin commented Aug 15, 2020

dimpase commented Aug 15, 2020

sagetrac-tmonteil mannequin commented Aug 19, 2020

kcrisman commented Aug 19, 2020

sagetrac-tmonteil mannequin commented Aug 19, 2020

EmmanuelCharpentier mannequin commented Aug 19, 2020

EmmanuelCharpentier mannequin commented Aug 19, 2020

mkoeppe commented Aug 19, 2020

slel commented Aug 19, 2020

This comment has been minimized.

vbraun commented Aug 20, 2020

sagetrac-tmonteil mannequin commented Aug 24, 2020

This comment has been minimized.