-
-
Notifications
You must be signed in to change notification settings - Fork 452
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sage.libs.ecl: Fix unicode handling #30106
Comments
This comment has been minimized.
This comment has been minimized.
comment:3
Not sure if there is a function in the ECL C API that constructs a Unicode Lisp string.
|
This comment has been minimized.
This comment has been minimized.
Commit: |
comment:7
Now
but more work is needed. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:9
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:11
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:13
|
Author: Matthias Koeppe |
comment:15
Thank you for solving this. Should our Maxima interface support unicode with this branch now, or do you know what else is needed to make this work? The following used to give an error, but results in a crash now:
Also, please add a doctest for the new functionality. |
comment:16
Are you on ecl 20.4 ? |
comment:17
Replying to @mwageringel:
Yes, I can confirm this here. I'll look into this.
Sure, will do. |
comment:18
Replying to @dimpase:
I'm still on 16.1.2. |
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:20
I suggest we work on ecl 20.4, for uniformity |
comment:21
The above error is due to a bug in ECL 16.1.2:
I will try with the ECL upgrade now. |
Branch pushed to git repo; I updated commit sha1. Last 10 new commits:
|
Branch pushed to git repo; I updated commit sha1. New commits:
|
comment:24
Replying to @mkoeppe:
This bug is still present in ECL 20.4.24. The above code is from Maxima's |
Dependencies: #22191 |
comment:27
Note that after commit ee97a6d, the test case from comment 17 now gives a proper error message, no longer a crash:
Fixing this ECL bug or working around it is outside of the scope of this ticket. |
comment:28
Ok, thanks for the fix. There is one more place where
Moreover, the docstring of Once that is fixed, you can set a positive review on my behalf. |
Reviewer: Markus Wageringel |
comment:30
Thank you! |
comment:31
Follow-up ticket to keep track of the ECL issue: #30122 |
Changed branch from u/mkoeppe/sage_libs_ecl__fix_unicode_handling to |
As a follow-up to #29278, #29280: If we use Unicode variable names in
SR
, declaring a domain gives an error:This comes from our ECL interface:
Also note:
Depends on #22191
CC: @mwageringel @nbruin @dimpase @spaghettisalat
Component: symbolics
Author: Matthias Koeppe
Branch/Commit:
59dd62b
Reviewer: Markus Wageringel
Issue created by migration from https://trac.sagemath.org/ticket/30106
The text was updated successfully, but these errors were encountered: