cygwin-minimal: pip-20.1.1 fails to install

[mkoeppe]

https://github.com/sagemath/sage/runs/862451271

  [pip-20.1.1]     File "/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/pip-20.1.1/src/src/pip/_vendor/urllib3/__init__.py", line 7, in <module>
  [pip-20.1.1]       from .connectionpool import HTTPConnectionPool, HTTPSConnectionPool, connection_from_url
  [pip-20.1.1]     File "/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/pip-20.1.1/src/src/pip/_vendor/urllib3/connectionpool.py", line 29, in <module>
  [pip-20.1.1]       from .connection import (
  [pip-20.1.1]     File "/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/pip-20.1.1/src/src/pip/_vendor/urllib3/connection.py", line 68, in <module>
  [pip-20.1.1]       class HTTPConnection(_HTTPConnection, object):
  [pip-20.1.1]     File "/cygdrive/d/a/sage/sage/local/var/tmp/sage/build/pip-20.1.1/src/src/pip/_vendor/urllib3/connection.py", line 96, in HTTPConnection
  [pip-20.1.1]       default_socket_options = [(socket.IPPROTO_TCP, socket.TCP_NODELAY, 1)]
  [pip-20.1.1]   AttributeError: module 'socket' has no attribute 'TCP_NODELAY'

The install on cygwin-standard works fine.

Upstream: Fixed upstream, but not in a stable release.

CC: @embray @slel @dimpase

Component: porting: Cygwin

Author: Matthias Koeppe

Branch/Commit: bc8c54f

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30127

[slel]

comment:1

Note that pip 20.2 was released.

[mkoeppe]

comment:2

Let's try with the following updates:

• https://pypi.org/project/pip/ 20.2.1 update (https://pip.pypa.io/en/stable/news/)

• https://pypi.org/project/setuptools/ 49.2.1

[mkoeppe]

Branch: u/mkoeppe/cygwin_minimal__pip_20_1_1_fails_to_install

[mkoeppe]

Changed branch from u/mkoeppe/cygwin_minimal__pip_20_1_1_fails_to_install to none

[mkoeppe]

comment:4

Tests at https://github.com/mkoeppe/sage/actions/runs/199487278

[mkoeppe]

Branch: u/mkoeppe/cygwin_minimal__pip_20_1_1_fails_to_install

[mkoeppe]

Commit: 91f21f6

[mkoeppe]

New commits:

a22b6ae	build/pkgs/pip: Update to 20.2.1
91f21f6	build/pkgs/setuptools: Update to 49.2.1

[mkoeppe]

comment:6

Same with pip 20.2.1 - https://github.com/mkoeppe/sage/runs/959258905

[mkoeppe]

comment:7

Should probably look at the python3 build log on this system.

[mkoeppe]

comment:8

The same error also with pip 20.1.1 and python3 3.8.5 from #27754.

[mkoeppe]

comment:9

Apparently caused by a recent change in the Cygwin headers: https://bugs.python.org/issue41374

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

bc8c54f

build/pkgs/python3/patches/cygwin-socket-tcpnodelay-21649.patch: New

[sagetrac-git]

Changed commit from 91f21f6 to bc8c54f

[mkoeppe]

Upstream: Fixed upstream, but not in a stable release.

[mkoeppe]

Author: Matthias Koeppe

[mkoeppe]

comment:12

Tests at https://github.com/mkoeppe/sage/actions/runs/199703638

[mkoeppe]

comment:14

This worked, as can be seen in https://github.com/mkoeppe/sage/runs/959927471

Needs review

[mkoeppe]

Reviewer: https://github.com/mkoeppe/sage/runs/959927471

[mkoeppe]

Changed reviewer from https://github.com/mkoeppe/sage/runs/959927471 to https://github.com/mkoeppe/sage/runs/959927471, ...

[mkoeppe]

comment:17

Let's get this in please

[dimpase]

Changed reviewer from https://github.com/mkoeppe/sage/runs/959927471, ... to https://github.com/mkoeppe/sage/runs/959927471, Dima Pasechnik

[dimpase]

comment:19

lgtm

[mkoeppe]

Changed reviewer from https://github.com/mkoeppe/sage/runs/959927471, Dima Pasechnik to Dima Pasechnik

[mkoeppe]

comment:20

Thanks!

[vbraun]

Changed branch from u/mkoeppe/cygwin_minimal__pip_20_1_1_fails_to_install to bc8c54f