deprecate edge_iterator

[dcoudert]

Now that we have EdgesView for graphs (#27408), we can use .edges(...) instead of .edge_iterator(...). We do the following:

Done:

• Add functionalities to edges(...) #30265 add missing parameters to method edges to have same behavior than edge_iterator

Todo:

• use edges instead of edge_iterator in the code
• make edge_iterator call edges
• add deprecation warning in edge_iterator

Component: graph theory

Reviewer: David Coudert, Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30145

[dcoudert]

Commit: 1a12ac5

[dcoudert]

New commits:

9a66fc3	add functionalities of edge_iterator to edges
ce7db5e	make edge_iterator call edges
82f5927	use edges instead of edge_iterator in graphs
2a85fda	use edges instead of edge_iterator almost everywhere
1a12ac5	add deprecation warning in edge_iterator

[dcoudert]

Branch: public/graphs/30145_deprecate_edge_iterator

[dcoudert]

comment:3

Green bot. Please review.

[dcoudert]

comment:4

I will split that into several smaller tickets. Too hard to make it at once.

[mkoeppe]

comment:7

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

[mkoeppe]

comment:8

Setting a new milestone for this ticket based on a cursory review.

[dcoudert]

comment:10

After second thought, I don't think anymore it is a good idea to deprecate edge_iterator. It avoids some overheads due to EdgeView and so is better for internal use.

Therefore, I propose to move this ticket to invalid/wontfix.

[tscrim]

Changed commit from 1a12ac5 to none

[tscrim]

Changed branch from public/graphs/30145_deprecate_edge_iterator to none

[tscrim]

Changed author from David Coudert to none

[tscrim]

Reviewer: David Coudert, Travis Scrimshaw

[tscrim]

comment:12

Then we will close this.