Modularization of sagelib: Break out a separate package sagemath-meataxe #30151

mkoeppe · 2020-07-15T21:46:10Z

... in analogy of #29864 (sage-tdlib).

To try: make sagemath_meataxe

(or ./configure --enable-sagemath_meataxe && make build)

This is part of #29705: Meta-ticket: Modularize sagelib into separate distributions (distutils packages)

Depends on #34346

CC: @simon-king-jena @kiwifb @jhpalmieri @dimpase

Component: packages: optional

Keywords: sd111

Work Issues: Rebase, rename "sage-..." -> "sagemath-..."

Branch/Commit: u/mkoeppe/modularization_of_sagelib__break_out_a_separate_package_sage_meataxe @ ebe1dd6

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30151

The text was updated successfully, but these errors were encountered:

mkoeppe · 2020-10-16T18:48:39Z

Branch: u/mkoeppe/modularization_of_sagelib__break_out_a_separate_package_sage_meataxe

sagetrac-git · 2020-10-16T18:57:35Z

Commit: b040746

sagetrac-git · 2020-10-16T18:57:35Z

Branch pushed to git repo; I updated commit sha1. New commits:

`16c60ca`	`src/setup.py: Remove meataxe - now taken care of by package sage_meataxe`
`b040746`	`fixup`

simon-king-jena · 2020-10-16T19:18:04Z

comment:3

Can you elaborate on what is supposed to be done to use meataxe --- both as a C library, as collection of executables, and as optional Cython extension module?

mkoeppe · 2020-10-16T19:58:52Z

comment:4

spkg meataxe stays as is. It installs the C library and executables. No dependency on anything from Sage.

spkg sagelib will no longer conditionally build the Cython extension module.

Instead, the new spkg sage_meataxe will build the Cython extension module. It declares both sagelib and meataxe as a dependency.

sage_meataxe, in the implementation of this ticket, does not have a source tarball (note there is no checksums.ini). Instead, it is a "script" package, whose sources lie in build/pkgs/sage_meataxe/src. It has the structure of a Python package (distribution), with setup.py doing the build and installation. The actual Cython sources remain in the src/sage tree (using symlinks). (It is possible to build a pip-installable source distribution tarball as well, using the spkg-src script. Eventually, we will upload it to PyPI.)

simon-king-jena · 2020-10-16T20:53:14Z

comment:5

Replying to @mkoeppe:

spkg sagelib will no longer conditionally build the Cython extension module.

Instead, the new spkg sage_meataxe will build the Cython extension module. It declares both sagelib and meataxe as a dependency.

So, in order to use it, one has to do make sage_meataxe, right? It would automatically install its dependency meataxe, would build the corresponding Cython extension module, AND would also build the documentation of the Cython extension module? And sage -testall would run the doctests from the corresponding Cython extension module if and only if sage_meataxe is installed, so that there is no need to mark all its tests as "optional"?

If the documentation and test suite would be taken care of, it would indeed be very helpful.

mkoeppe · 2020-10-16T20:59:25Z

comment:6

Replying to @simon-king-jena:

Replying to @mkoeppe:

spkg sagelib will no longer conditionally build the Cython extension module.

Instead, the new spkg sage_meataxe will build the Cython extension module. It declares both sagelib and meataxe as a dependency.

So, in order to use it, one has to do make sage_meataxe, right? It would automatically install its dependency meataxe, would build the corresponding Cython extension module, AND would also build the documentation of the Cython extension module?

Yes.

And sage -testall would run the doctests from the corresponding Cython extension module if and only if sage_meataxe is installed, so that there is no need to mark all its tests as "optional"?

Yes, I would hope so. I have just created #30778 for this idea.

sagetrac-git · 2020-10-17T02:00:50Z

Changed commit from b040746 to 1e03fef

sagetrac-git · 2020-10-17T02:00:50Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. Last 10 new commits:

`b060462`	`sage_setup.find.find_python_sources: Handle native namespace packages, 'nonamespace' files`
`d42aa12`	`is_package_or_namespace_package_dir: New, recognize namespace packages by file 'namespace', monkeypatch into Cython`
`29ca24b`	`Make sage.graphs, sage.matrix, sage.libs, sage.interfaces namespace packages`
`1957acd`	`src/sage_setup/clean.py: Update comment`
`8b37214`	`WIP`
`92f1145`	`sage_install_and_clean: If all_distributions is a list, do not clean files that do not belong to this list`
`44a4456`	`src/sage_setup/command/sage_install.py: Also handle modules in namespace packages`
`706bf59`	`Merge branch 't/28925/modify_find_python_sources__clean_stale_files_to_support_modularization_of_sagelib_by_native_namespace_packages__pep_420_' into t/30151/modularization_of_sagelib__break_out_a_separate_package_sage_meataxe`
`f096870`	`build/pkgs/sage_meataxe: New`
`1e03fef`	`src/setup.py: Remove meataxe - now taken care of by package sage_meataxe`

sagetrac-git · 2020-10-17T02:20:16Z

Branch pushed to git repo; I updated commit sha1. New commits:

`ad9402f`	`sage_setup.command.sage_install: Fixup: Remove cleaning code (moved to sage_install_and_clean)`
`88455dc`	`Merge branch 't/30780/sage_setup__separate_installing_and_cleaning' into t/28925/modify_find_python_sources__clean_stale_files_to_support_modularization_of_sagelib_by_native_namespace_packages__pep_420_`
`aacec42`	`Merge branch 't/28925/modify_find_python_sources__clean_stale_files_to_support_modularization_of_sagelib_by_native_namespace_packages__pep_420_' into t/30151/modularization_of_sagelib__break_out_a_separate_package_sage_meataxe`

sagetrac-git · 2020-10-17T02:20:16Z

Changed commit from 1e03fef to aacec42

sagetrac-git · 2020-10-17T02:27:23Z

Changed commit from aacec42 to ac10389

sagetrac-git · 2020-10-17T02:27:23Z

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

`800f740`	`Merge branch 't/28925/modify_find_python_sources__clean_stale_files_to_support_modularization_of_sagelib_by_native_namespace_packages__pep_420_' into t/30151/modularization_of_sagelib__break_out_a_separate_package_sage_meataxe`
`3823197`	`build/pkgs/sage_meataxe: New`
`ac10389`	`build/pkgs/sagelib/src/setup.py: Remove meataxe - now taken care of by package sage_meataxe`

sagetrac-git · 2020-10-17T02:32:35Z

Branch pushed to git repo; I updated commit sha1. New commits:

`12b22d9`	`fixup`

sagetrac-git · 2020-10-17T02:32:35Z

Changed commit from ac10389 to 12b22d9

sagetrac-git · 2020-10-17T02:33:26Z

Changed commit from 12b22d9 to 500635d

sagetrac-git · 2020-10-17T02:33:26Z

Branch pushed to git repo; I updated commit sha1. New commits:

`500635d`	`fixup`

sagetrac-git · 2020-10-17T03:14:57Z

Branch pushed to git repo; I updated commit sha1. New commits:

`3d3cc42`	`build/pkgs/sage_meataxe/spkg-install: Install via bdist_wheel`

sagetrac-git · 2020-10-17T03:14:57Z

Changed commit from 500635d to 3d3cc42

sagetrac-git · 2020-10-17T04:31:55Z

Branch pushed to git repo; I updated commit sha1. New commits:

`99f3cc7`	`build/pkgs/sage_meataxe/src/setup.py: Set built_distributions`
`a9933b6`	`sage_build_cython: Pass built_distributions to find_extra_files`
`10e2432`	`Merge branch 't/28925/modify_find_python_sources__clean_stale_files_to_support_modularization_of_sagelib_by_native_namespace_packages__pep_420_' into t/30151/modularization_of_sagelib__break_out_a_separate_package_sage_meataxe`

sagetrac-git · 2020-10-17T04:31:55Z

Changed commit from 3d3cc42 to 10e2432

mkoeppe · 2020-10-17T04:33:16Z

comment:14

The installation seems to work, but Sage cannot start because of a circular import related from sage.matrix.args. This needs a bit more work.

mkoeppe · 2020-10-17T04:33:16Z

Author: Matthias Koeppe

simon-king-jena · 2020-10-17T11:34:44Z

Changed dependencies from #28925 to #28925 #28711

mkoeppe · 2020-12-09T01:25:22Z

Changed work issues from Rebase to Rebase, rename "sage-..." -> "sagemath-..."

sagetrac-git · 2020-12-09T05:39:22Z

Branch pushed to git repo; I updated commit sha1. New commits:

`a6e8447`	`Merge tag '9.3.beta3' into t/28925/modify_find_python_sources__clean_stale_files_to_support_modularization_of_sagelib_by_native_namespace_packages__pep_420_`
`ebe1dd6`	`Merge branch 't/28925/modify_find_python_sources__clean_stale_files_to_support_modularization_of_sagelib_by_native_namespace_packages__pep_420_' into t/30151/modularization_of_sagelib__break_out_a_separate_package_sage_meataxe`

sagetrac-git · 2020-12-09T05:39:22Z

Changed commit from 7cedb3d to ebe1dd6

mkoeppe · 2021-02-13T20:51:01Z

comment:36

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

mkoeppe · 2021-07-19T00:44:56Z

comment:37

Setting a new milestone for this ticket based on a cursory review.

mkoeppe · 2022-11-16T07:36:22Z

Changed dependencies from #28925 to #34346

mkoeppe · 2022-11-16T07:36:22Z

Changed author from Matthias Koeppe to none

mkoeppe · 2022-11-16T07:36:22Z

comment:41

This is now done in #34346.

dimpase · 2022-11-16T12:59:37Z

Reviewer: Dima Pasechnik

mkoeppe added this to the sage-9.3 milestone Jul 15, 2020

mkoeppe added c: packages: optional labels Jul 15, 2020

This comment has been minimized.

Sign in to view

mkoeppe added s: needs work and removed s: needs review labels Dec 6, 2020

This comment has been minimized.

Sign in to view

mkoeppe changed the title ~~Modularization of sagelib: Break out a separate package sage-meataxe~~ Modularization of sagelib: Break out a separate package sagemath-meataxe Dec 9, 2020

mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021

mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021

mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021

mkoeppe modified the milestones: sage-9.6, sage-9.7 Apr 2, 2022

mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 6, 2022

mkoeppe removed this from the sage-9.8 milestone Nov 16, 2022

mkoeppe added s: needs review and removed s: needs work labels Nov 16, 2022

dimpase added s: positive review and removed s: needs review labels Nov 16, 2022

mkoeppe removed the s: positive review label Jan 1, 2023

mkoeppe closed this as completed Jan 1, 2023

Modularization of sagelib: Break out a separate package sagemath-meataxe #30151

Modularization of sagelib: Break out a separate package sagemath-meataxe #30151

Comments

mkoeppe commented Jul 15, 2020

mkoeppe commented Oct 16, 2020

sagetrac-git mannequin commented Oct 16, 2020

sagetrac-git mannequin commented Oct 16, 2020

simon-king-jena commented Oct 16, 2020

mkoeppe commented Oct 16, 2020

simon-king-jena commented Oct 16, 2020

mkoeppe commented Oct 16, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

sagetrac-git mannequin commented Oct 17, 2020

mkoeppe commented Oct 17, 2020

mkoeppe commented Oct 17, 2020

This comment has been minimized.

This comment has been minimized.

simon-king-jena commented Oct 17, 2020

This comment has been minimized.

mkoeppe commented Dec 9, 2020

sagetrac-git mannequin commented Dec 9, 2020

sagetrac-git mannequin commented Dec 9, 2020

mkoeppe commented Feb 13, 2021

mkoeppe commented Jul 19, 2021

mkoeppe commented Nov 16, 2022

mkoeppe commented Nov 16, 2022

mkoeppe commented Nov 16, 2022

dimpase commented Nov 16, 2022