Merge duplications in edges, ridges and f-vector of combinatorial polyhedron

[kliem]

We merge some duplications of obtaining edges, ridges and f-vector.

There was an entire copy of getting edges/ridges that also obtained the f-vector. But it is much simpler doing this directly in the f-vector code.

Also getting the edges/ridges is almost the same thing. We can let the FaceIterator worry about the details.

Depends on #30443

CC: @jplab @LaisRast @tscrim

Component: geometry

Keywords: code duplication, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: 62b3d9f

Reviewer: Travis Scrimshaw

Issue created by migration from https://trac.sagemath.org/ticket/30445

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:4

Some minor formatting things (which you can either change or ignore and then set this to a positive review):

-    cdef size_t _compute_edges_or_ridges_with_iterator(self, FaceIterator face_iter, bint do_atom_rep, size_t ***edges_pt, size_t *counter_pt, size_t *current_length_pt, MemoryAllocator mem) except -1:
+    cdef size_t _compute_edges_or_ridges_with_iterator(self, FaceIterator face_iter,
+                                                       bint do_atom_rep,
+                                                       size_t ***edges_pt,
+                                                       size_t *counter_pt,
+                                                       size_t *current_length_pt,
+                                                       MemoryAllocator mem) except -1:
         r"""
         See :meth:`CombinatorialPolyhedron._compute_edges`.
         """
         cdef size_t a,b                # facets of an edge
         cdef int dim = self.dimension()
         cdef output_dimension = 1 if do_atom_rep else dim - 2
 
-        while (face_iter.next_dimension() == output_dimension):
+        while face_iter.next_dimension() == output_dimension:

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

cbc711d	Merge branch 'u/gh-kliem/merge_edges_ridges_f_vector' of git://trac.sagemath.org/sage into u/gh-kliem/merge_edges_ridges_f_vector
62b3d9f	formating

[sagetrac-git]

Changed commit from 8814532 to 62b3d9f

[kliem]

comment:6

Thank you.

[vbraun]

Changed branch from u/gh-kliem/merge_edges_ridges_f_vector to 62b3d9f