Outsource some functions in bit_vector_operations.cc

[kliem]

We simplify obtaining the inclusion maximal faces in the function
get_next_level by outsourcing to new function is_contained_in_one.

In addition we implement contains_one for #30040.

This ticket merges cleanly with #30435.

Component: geometry

Keywords: code duplication, combinatorial polyhedron

Author: Jonathan Kliem

Branch/Commit: 5311cdf

Reviewer: Travis Scrimshaw, Samuel Lelièvre

Issue created by migration from https://trac.sagemath.org/ticket/30458

[kliem]

Branch: u/gh-kliem/outsource_inclusion_maximal

[kliem]

New commits:

20a39b6

outsource inclusion maximal

[kliem]

Commit: 20a39b6

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b672fca

removed redundant function

[sagetrac-git]

Changed commit from 20a39b6 to b672fca

[tscrim]

Reviewer: Travis Scrimshaw

[tscrim]

comment:3

LGTM.

[kliem]

comment:4

Thank you.

[slel]

comment:5

The functions inline int is_contained_in_one (with or without skip)
have this fine description:

     Return whether ``face`` is contained in one of ``faces``.

Descriptions for the functions contains_one (with or without skip)
have a problem:

 inline int contains_one(uint64_t *face, uint64_t **faces, size_t n_faces, size_t face_length){
     /*
-    Return whether ``face`` contains in one of ``faces``.
+    Return whether ``face`` contains one of ``faces``.
     */

 inline int contains_one(uint64_t *face, uint64_t **faces, size_t n_faces, size_t face_length, size_t skip){
     /*
-    Return whether ``face`` is contains in one of ``faces``.
+    Return whether ``face`` contains one of ``faces``.
 
     Skips ``faces[skip]``.
     */

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1. New commits:

b2ce23e

grammar

[sagetrac-git]

Changed commit from b672fca to b2ce23e

[slel]

Changed reviewer from Travis Scrimshaw to Travis Scrimshaw, Samuel Lelièvre

[kliem]

comment:9

Thanks again.

[sagetrac-git]

Branch pushed to git repo; I updated commit sha1 and set ticket back to needs_review. This was a forced push. New commits:

7c970e3	outsource inclusion maximal
92fb29c	removed redundant function
5311cdf	grammar

[sagetrac-git]

Changed commit from b2ce23e to 5311cdf

[kliem]

comment:11

Rebased.

[vbraun]

Changed branch from u/gh-kliem/outsource_inclusion_maximal to 5311cdf