Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

src/bin/sage-env, src/bin/sage-env-config.in: Remove PYTHON_FOR_VENV #30724

Closed
mkoeppe opened this issue Oct 5, 2020 · 10 comments
Closed

src/bin/sage-env, src/bin/sage-env-config.in: Remove PYTHON_FOR_VENV #30724

mkoeppe opened this issue Oct 5, 2020 · 10 comments
Labels
c: build: configure p: major / 3 t: enhancement
Milestone
sage-9.3

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Oct 5, 2020

Instead, define it in build/make/Makefile.in.

With this ticket, the MACOSX_DEPLOYMENT_TARGET handling uses a new (unexported) configuration variable defined by sage-env-config; see also #30711.

This cleans up the sage runtime environment - one fewer environment variable.

It is also preparation for #29013.

CC: @jhpalmieri @dimpase @kiwifb

Component: build: configure

Author: Matthias Koeppe

Branch/Commit: 4bfa0ea

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30724
@mkoeppe mkoeppe added this to the sage-9.2 milestone Oct 5, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 5, 2020

Branch: u/mkoeppe/src_bin_sage_env__src_bin_sage_env_config_in__remove_python_for_venv

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 5, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 5, 2020

New commits:

91b4c0fbuild/make/Makefile.in: Set PYTHON_FOR_VENV here, do not rely on sage-env to set it
1955fadsrc/bin/sage-env: Set MACOSX_DEPLOYMENT_TARGET based on config variable SAGE_MACOSX_DEPLOYMENT_TARGET
4bfa0easrc/bin/sage-env-config.in: Do not set PYTHON_FOR_VENV

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Oct 5, 2020

Commit: 4bfa0ea

@mkoeppe mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 7, 2020

comment:4

Needs review

@dimpase
Copy link
Member

dimpase commented Nov 7, 2020

comment:5

ok, this works

@dimpase
Copy link
Member

dimpase commented Nov 7, 2020

Reviewer: Dima Pasechnik

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 7, 2020

comment:6

Thanks!

@vbraun
Copy link
Member

vbraun commented Nov 20, 2020

Changed branch from u/mkoeppe/src_bin_sage_env__src_bin_sage_env_config_in__remove_python_for_venv to 4bfa0ea

@vbraun vbraun closed this as completed in 1ac30ab Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build: configure p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-9.3
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe