cython_aliases: Use ecl-config to determine compiler/linker flags for ecl #30770

mkoeppe · 2020-10-15T03:25:08Z

We use ecl-config to determine compiler/linker flags for ecl. This is a step towards using a system-installed ecl and is needed/helpful for installing sage in virtual environments (#30371).

$ ecl-config --help
Usage: /usr/local/bin/ecl-config [OPTIONS] [LIBS]
Options: 
	[--cflags]
	[--libs|--ldflags]
Libs:
	cmp

Sample output:

> ./local/bin/ecl-config --cflags --libs
-Dlinux   -I/mnt/d/Programming/sage/local/include
-Wl,--rpath,/mnt/d/Programming/sage/local/lib -L/mnt/d/Programming/sage/local/lib -lecl -Wl,-rpath-link,/mnt/d/Programming/sage/local/lib -L/mnt/d/Programming/sage/local/lib -Wl,-rpath,/mnt/d/Programming/sage/local/lib      -ldl -lm

CC: @dimpase @orlitzky @spaghettisalat @jhpalmieri @tobiasdiez @isuruf @kiwifb @antonio-rojas

Component: build

Keywords: sd111

Author: Tobias Diez, Matthias Koeppe

Branch: 11ad40a

Reviewer: Matthias Koeppe, Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30770

The text was updated successfully, but these errors were encountered:

mkoeppe · 2020-11-01T16:35:49Z

comment:2

Ideally, of course, ecl would install a pkg-config module...

mkoeppe · 2020-12-06T18:17:38Z

comment:3

Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111

mkoeppe · 2020-12-06T18:17:38Z

Changed keywords from none to sd111

tobiasdiez · 2021-01-11T14:53:19Z

Commit: 3049e53

tobiasdiez · 2021-01-11T14:53:19Z

Branch: public/build/ecl-config

tobiasdiez · 2021-01-11T14:53:19Z

Author: Tobias Diez

tobiasdiez · 2021-01-11T14:53:19Z

comment:6

The following is working for me (in the context of #30371).

New commits:

`3049e53`	`Use ecl-config to determine compiler/linker flags for ecl`

mkoeppe · 2021-01-11T17:13:40Z

comment:7

Following the conventions of autoconf, this variable should be called ECL_CONFIG, not ECL_CONFIG_PATH

sagetrac-git · 2021-01-12T12:14:18Z

Branch pushed to git repo; I updated commit sha1. New commits:

`1041128`	`Rename ecl config variable`

sagetrac-git · 2021-01-12T12:14:18Z

Changed commit from 3049e53 to 1041128

tobiasdiez · 2021-01-12T12:28:00Z

comment:9

Replying to @mkoeppe:

Following the conventions of autoconf, this variable should be called ECL_CONFIG, not ECL_CONFIG_PATH

I'm not sure if one should follow the autoconf conventions here since the variable is (right now) only used in python scripts, but I've renamed it anyway.

mkoeppe · 2021-01-12T17:13:11Z

comment:10

capture_output is not available on Python 3.6 - see #30758

tobiasdiez · 2021-01-12T21:48:01Z

Dependencies: #30551

mkoeppe · 2021-01-12T23:16:31Z

comment:12

I think it's better to make the simple change of the code as in sagemath/sagetrac-mirror@a569b88
instead of deferring this ticket until after we drop support for python 3.6

dimpase · 2021-01-13T14:29:47Z

comment:13

I have yet to see a system that ships patched ECL, allowing one to build Maxima in Sage, etc.

tobiasdiez · 2021-01-13T14:49:38Z

comment:14

I use this ticket successfully in #30371 to build sage in a new python virtual environment using sage's ecl precisely because the system ecl is not working.

mkoeppe · 2021-01-13T17:44:48Z

comment:15

Replying to @dimpase:

I have yet to see a system that ships patched ECL, allowing one to build Maxima in Sage, etc.

Surely distributions that ship sage must have a suitable package: conda, arch, ...?

antonio-rojas · 2021-01-13T21:00:15Z

comment:17

@@ -203,6 +204,7 @@ var('MAXIMA_FAS')
 var('SAGE_NAUTY_BINS_PREFIX',        '')
 var('ARB_LIBRARY',                   'arb')
 var('CBLAS_PC_MODULES',              'cblas:openblas:blas')
+var('ECL_CONFIG')
 
 # misc
 var('SAGE_BANNER', '')

Please add a fallback here, otherwise this will break distro packaging without sage_conf

antonio-rojas · 2021-01-13T21:02:37Z

comment:18

Given that sage's maxima is patched to install a fas module in ecl's tree, how is this supposed to work with a system ecl?

mkoeppe · 2021-01-13T21:14:18Z

comment:19

I think we can change our maxima installation to use a different installation directoery and then pass the full path using the existing variable sage.env.MAXIMA_FAS

mkoeppe · 2021-01-13T23:51:14Z

comment:20

Replying to @antonio-rojas:

@@ -203,6 +204,7 @@ var('MAXIMA_FAS')
 var('SAGE_NAUTY_BINS_PREFIX',        '')
 var('ARB_LIBRARY',                   'arb')
 var('CBLAS_PC_MODULES',              'cblas:openblas:blas')
+var('ECL_CONFIG')
 
 # misc
 var('SAGE_BANNER', '')

Please add a fallback here, otherwise this will break distro packaging without sage_conf

I agree, this should fall back to just 'ecl-config'

tobiasdiez · 2021-01-14T09:15:27Z

comment:21

Good catch, I've now added a fallback!

mkoeppe · 2021-01-15T17:51:44Z

Changed author from Tobias Diez to Tobias Diez, Matthias Koeppe

sagetrac-git · 2021-01-16T04:35:34Z

Changed commit from 6370c34 to 31f1bbb

sagetrac-git · 2021-01-16T04:35:34Z

Branch pushed to git repo; I updated commit sha1. New commits:

`31f1bbb`	`Also use universal_newlines instead of text, for python 3.6 compatibility`

dimpase · 2021-01-16T10:19:10Z

comment:29

Replying to @sagetrac-git:

Branch pushed to git repo; I updated commit sha1. New commits:

`31f1bbb`	`Also use universal_newlines instead of text, for python 3.6 compatibility`

Why do you push Python-3.6-needed changes to a ticket that depends on #30551 ?
It just makes no sense to me.

mkoeppe · 2021-01-16T16:34:51Z

comment:30

Thanks. I forgot to remove the dependency.

mkoeppe · 2021-01-16T16:34:51Z

Changed dependencies from #30551 to none

mkoeppe · 2021-01-16T18:32:51Z

comment:31

Replying to @antonio-rojas:

Given that sage's maxima is patched to install a fas module in ecl's tree, how is this supposed to work with a system ecl?

Where do distributions install compiled common lisp libraries?

kiwifb · 2021-01-16T19:57:35Z

comment:32

Replying to @mkoeppe:

Replying to @antonio-rojas:

Given that sage's maxima is patched to install a fas module in ecl's tree, how is this supposed to work with a system ecl?

Where do distributions install compiled common lisp libraries?

Gentoo does it in /usr/lib64/ecl-20.4.24 - as can be seen it is versioned. This is the place where ecl put a lot of its own libraries. It is determined by running the following ecl lisp formula, which I believe is the same in vanilla sage.

ecl -eval "(princ (SI:GET-LIBRARY-PATHNAME))" -eval "(quit)"

It could be interesting to know other, or how to set other, paths to install .fas files for ecl.

spaghettisalat · 2021-01-17T19:10:37Z

comment:33

Replying to @kiwifb:

Replying to @mkoeppe:

Replying to @antonio-rojas:

Given that sage's maxima is patched to install a fas module in ecl's tree, how is this supposed to work with a system ecl?

Where do distributions install compiled common lisp libraries?

Gentoo does it in /usr/lib64/ecl-20.4.24 - as can be seen it is versioned. This is the place where ecl put a lot of its own libraries. It is determined by running the following ecl lisp formula, which I believe is the same in vanilla sage.
ecl -eval "(princ (SI:GET-LIBRARY-PATHNAME))" -eval "(quit)"
It could be interesting to know other, or how to set other, paths to install .fas files for ecl.

There is no universally agreed place to put .fas files, after all you can just use (load "/wherever/whatever.fas") to load them from any place you like. But /usr/lib64/ecl-20.4.24 makes the most sense for libraries useable for multiple projects and also allows you to call (require :whatever) to use the fas in ECL. On the other hand, if the .fas file is only useable for a single project, I would rather put it in /usr/lib64/some-other-project/ and explicitely load it from there.

mkoeppe · 2021-01-17T19:13:20Z

Reviewer: Matthias Koeppe, ...

kiwifb · 2021-01-17T19:14:23Z

comment:35

This is extremely interesting, how would you load a .fas from an arbitrary location?

spaghettisalat · 2021-01-17T19:19:06Z

comment:36

Replying to @kiwifb:

This is extremely interesting, how would you load a .fas from an arbitrary location?

As I said, you just call (load "/path/to/lib.fas"). This is a standard common lisp function for loading compiled code or source code into the running image, much like dlopen loads a shared library in C.

sagetrac-git · 2021-01-19T16:32:46Z

Changed commit from 31f1bbb to 11ad40a

sagetrac-git · 2021-01-19T16:32:46Z

Branch pushed to git repo; I updated commit sha1. New commits:

`2ac4cc8`	`Merge branch 'develop' of git://github.com/sagemath/sage into public/build/ecl-config`
`11ad40a`	`Merge branch 'public/build/ecl-config' of git://trac.sagemath.org/sage into public/build/ecl-config`

mkoeppe · 2021-01-19T21:31:38Z

comment:38

Let's continue the discussion on Maxima FASL installation in #29617 (spkg-configure.m4 and distros/ information for ecl)

The present ticket is about the parameters for compiling the sage.libs.ecl extension. Needs review

mkoeppe · 2021-02-02T21:04:14Z

comment:39

Let's please get this in

dimpase · 2021-02-03T00:38:12Z

comment:40

lgtm

dimpase · 2021-02-03T00:38:12Z

Changed reviewer from Matthias Koeppe, ... to Matthias Koeppe, Dima Pasechnik

tobiasdiez · 2021-02-03T09:21:05Z

comment:41

Thanks!

vbraun · 2021-02-20T10:46:49Z

Changed branch from public/build/ecl-config to 11ad40a

mkoeppe · 2022-05-05T17:18:04Z

Changed commit from 11ad40a to none

mkoeppe · 2022-05-05T17:18:04Z

comment:43

Follow up in #33803

mkoeppe added this to the sage-9.2 milestone Oct 15, 2020

mkoeppe added c: build labels Oct 15, 2020

mkoeppe modified the milestones: sage-9.2, sage-9.3 Oct 24, 2020

This comment has been minimized.

Sign in to view

tobiasdiez added the s: needs review label Jan 11, 2021

mkoeppe added s: needs review and removed s: needs work labels Jan 15, 2021

mkoeppe added p: critical / 2 and removed p: major / 3 labels Feb 2, 2021

dimpase added s: positive review and removed s: needs review labels Feb 3, 2021

vbraun removed the s: positive review label Feb 20, 2021

vbraun closed this as completed in 94156f6 Feb 20, 2021

cython_aliases: Use ecl-config to determine compiler/linker flags for ecl #30770

cython_aliases: Use ecl-config to determine compiler/linker flags for ecl #30770

Comments

mkoeppe commented Oct 15, 2020

mkoeppe commented Nov 1, 2020

mkoeppe commented Dec 6, 2020

mkoeppe commented Dec 6, 2020

tobiasdiez commented Jan 11, 2021

This comment has been minimized.

tobiasdiez commented Jan 11, 2021

tobiasdiez commented Jan 11, 2021

tobiasdiez commented Jan 11, 2021

mkoeppe commented Jan 11, 2021

sagetrac-git mannequin commented Jan 12, 2021

sagetrac-git mannequin commented Jan 12, 2021

tobiasdiez commented Jan 12, 2021

mkoeppe commented Jan 12, 2021

tobiasdiez commented Jan 12, 2021

mkoeppe commented Jan 12, 2021

dimpase commented Jan 13, 2021

tobiasdiez commented Jan 13, 2021

mkoeppe commented Jan 13, 2021

antonio-rojas commented Jan 13, 2021

antonio-rojas commented Jan 13, 2021

mkoeppe commented Jan 13, 2021

mkoeppe commented Jan 13, 2021

tobiasdiez commented Jan 14, 2021

mkoeppe commented Jan 15, 2021

sagetrac-git mannequin commented Jan 16, 2021

sagetrac-git mannequin commented Jan 16, 2021

dimpase commented Jan 16, 2021

mkoeppe commented Jan 16, 2021

mkoeppe commented Jan 16, 2021

mkoeppe commented Jan 16, 2021

kiwifb commented Jan 16, 2021

spaghettisalat commented Jan 17, 2021

mkoeppe commented Jan 17, 2021

kiwifb commented Jan 17, 2021

spaghettisalat commented Jan 17, 2021

sagetrac-git mannequin commented Jan 19, 2021

sagetrac-git mannequin commented Jan 19, 2021

mkoeppe commented Jan 19, 2021

mkoeppe commented Feb 2, 2021

dimpase commented Feb 3, 2021

dimpase commented Feb 3, 2021

tobiasdiez commented Feb 3, 2021

vbraun commented Feb 20, 2021

mkoeppe commented May 5, 2022

mkoeppe commented May 5, 2022