Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sage.doctest.control, sage_setup: Do not check versions of installed packages #30848

Closed
mkoeppe opened this issue Nov 2, 2020 · 5 comments
Closed

sage.doctest.control, sage_setup: Do not check versions of installed packages #30848

mkoeppe opened this issue Nov 2, 2020 · 5 comments
Labels
c: build p: major / 3 t: enhancement
Milestone
sage-10.4

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 2, 2020

For a long time now, the Makefile ensures that packages are automatically reinstalled when the version in build/pkgs/SPKG/package-version.txt changes.

Thus we now remove the check whether the installed package version is current from sage.doctest.control and sage_setup (ex OptionalExtension code).

This simplifies the code, and in particular removes the direct reading of build/pkgs/ from sagelib.

CC: @dimpase @jhpalmieri @kiwifb

Component: build

Keywords: sd111

Branch: u/mkoeppe/sage_doctest_control__sage_setup__do_not_check_versions_of_installed_packages

Issue created by migration from https://trac.sagemath.org/ticket/30848
@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 2, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 11, 2020

Branch: u/mkoeppe/sage_doctest_control__sage_setup__do_not_check_versions_of_installed_packages

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

comment:2

Hoping we can make progress on this ticket this week - https://wiki.sagemath.org/days111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 6, 2020

Changed keywords from none to sd111

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 13, 2021

comment:3

Setting new milestone based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Feb 13, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Jul 19, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 14, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.7 Mar 5, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.7, sage-9.8 Aug 31, 2022
@mkoeppe mkoeppe modified the milestones: sage-9.8, sage-9.9 Jan 7, 2023
@mkoeppe mkoeppe removed this from the sage-10.0 milestone Mar 16, 2023
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Aug 5, 2024

Completed in #37857

@mkoeppe mkoeppe closed this as completed Aug 5, 2024
@mkoeppe mkoeppe added this to the sage-10.4 milestone Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: build p: major / 3 t: enhancement
Projects
None yet
Milestone
sage-10.4
Development

No branches or pull requests
1 participant
@mkoeppe