Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH Actions: Update macos test environments #30929

Closed
mkoeppe opened this issue Nov 17, 2020 · 23 comments
Closed

GH Actions: Update macos test environments #30929

mkoeppe opened this issue Nov 17, 2020 · 23 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 17, 2020

https://github.com/actions/virtual-environments

Big Sur:

actions/runner-images#1814: macOS Big Sur (11.0) is available as a preview for GitHub Action users!

To use it set runs-on: macos-11.0 in your workflow file.

Details: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-11.0-Readme.md

  • 12.3 (beta) 12C5020f /Applications/Xcode_12.3.app
  • 12.2 12B5044c /Applications/Xcode_12.2.app
  • 11.7 (default) 11E801a /Applications/Xcode_11.7.app

Catalina: https://github.com/actions/virtual-environments/blob/main/images/macos/macos-10.15-Readme.md

  • 12.3 (beta) 12C5020f /Applications/Xcode_12.3.app
  • 12.2 12B45b /Applications/Xcode_12.2.app
  • 12.1.1 12A7605b /Applications/Xcode_12.1.1.app
  • 12.1 12A7403 /Applications/Xcode_12.1.app
  • 12.0.1 (default) 12A7300 /Applications/Xcode_12.app
  • 11.7 11E801a /Applications/Xcode_11.7.app

Previous update: #30487 - which added testing with Xcode 12 on Catalina.

See also: #30726 GH Actions: Test optional/experimental packages with Xcode 12

CC: @jhpalmieri @dimpase

Component: porting

Author: Matthias Koeppe

Branch/Commit: 7ae8cf1

Reviewer: Jonathan Kliem

Issue created by migration from https://trac.sagemath.org/ticket/30929

@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 17, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

Commit: 8df49f1

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

New commits:

8df49f1.github/workflows/tox.yml: Test with macOS 11, update Xcode versions

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2020

comment:5

(wrong ticket)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2020

Changed commit from 8df49f1 to ee388dc

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

comment:6

(wrong ticket)

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 17, 2020

Changed commit from ee388dc to 8df49f1

@mkoeppe

This comment has been minimized.

@slel

This comment has been minimized.

@kliem
Copy link
Contributor

kliem commented Nov 25, 2020

comment:10

I'm a bit confused that you use

+    runs-on: ${{ matrix.os }}

before declaring it.

The other thing is that things have moved on already. Beta 12.3 is available and 12.2 is the default, once this ticket is merged (and no longer beta). So the description of this ticket should be updated accordingly.

Does it make sense to test 12.3 already?

Otherwise this looks fine.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 25, 2020

comment:11

Replying to @kliem:

I'm a bit confused that you use

+    runs-on: ${{ matrix.os }}

before declaring it.

Whatever works is part of the operational semantics of this language

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 25, 2020

Changed commit from 8df49f1 to 7ae8cf1

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Nov 25, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

92221b9.github/workflows/tox.yml: Test with macOS 11, update Xcode versions
ce2a3c5.github/workflows/tox.yml: Test Xcode 11.7, default, 12.3
7ae8cf1.github/workflows/tox-{optional,experimental}.yml: Update macos jobs

@kliem
Copy link
Contributor

kliem commented Nov 25, 2020

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/367209097 to Jonathan Kliem

@kliem
Copy link
Contributor

kliem commented Nov 25, 2020

comment:15

LGTM.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 25, 2020

comment:16

Thanks!

@vbraun
Copy link
Member

vbraun commented Dec 5, 2020

Changed branch from u/mkoeppe/gh_actions__update_macos_test_environments to 7ae8cf1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants