Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH Actions: Repair upload of docker images to docker.pkg.github.com #30933

Closed
mkoeppe opened this issue Nov 17, 2020 · 22 comments
Closed

GH Actions: Repair upload of docker images to docker.pkg.github.com #30933

mkoeppe opened this issue Nov 17, 2020 · 22 comments
Labels
c: porting p: blocker / 1 t: bug
Milestone
sage-9.5

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 17, 2020

These docker images are built by the portability CI workflows for Linux.

However, refactoring of the workflow had broken the upload to docker.pkg.github.com. (Although the login to docker.pkg.github.com succeeds, the push fails with no basic auth credentials - see https://github.com/mkoeppe/sage/runs/1414148202?check_suite_focus=true)

CC: @kliem @dimpase @tobiasdiez

Component: porting

Author: Matthias Koeppe

Branch/Commit: 21afe51

Reviewer: Dima Pasechnik

Issue created by migration from https://trac.sagemath.org/ticket/30933
@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 17, 2020
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

comment:1

This is possibly because tox does not pass on $HOME - and docker login stores the password in /home/runner/.docker/config.json.

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 17, 2020

comment:2

docker login recommends to configure a credential helper -
https://docs.docker.com/engine/reference/commandline/login/#credentials-store

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 18, 2020

Branch: u/mkoeppe/gh_actions__repair_upload_of_docker_images

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 18, 2020

Author: Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 18, 2020

Commit: 1bb3b33

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 18, 2020

New commits:

e8afd96.github/workflows/tox*.yml: Use new method to set environment variable for next GH Actions steps
1bb3b33.github/workflows/tox*.yml: Install pass for docker push

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 18, 2020

Reviewer: https://github.com/mkoeppe/sage/actions/runs/369629393

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Nov 18, 2020

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/369629393 to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Mar 24, 2021

comment:6

Sage development has entered the release candidate phase for 9.3. Setting a new milestone for this ticket based on a cursory review of ticket status, priority, and last modification date.

@mkoeppe mkoeppe modified the milestones: sage-9.3, sage-9.4 Mar 24, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.4, sage-9.5 Aug 9, 2021
@mkoeppe mkoeppe modified the milestones: sage-9.5, sage-9.6 Dec 27, 2021
@mkoeppe mkoeppe changed the title GH Actions: Repair upload of docker images GH Actions: Repair upload of docker images to docker.pkg.github.com Dec 31, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 31, 2021

Changed commit from 1bb3b33 to 0644259

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 31, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

0644259.github/workflows/tox*.yml, tox.ini: Pass ddocker.pkg.github.com credentials via DOCKER_CONFIG_FILE

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 31, 2021

Changed dependencies from #30733 to none

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Dec 31, 2021

Reviewer: https://github.com/mkoeppe/sage/actions/runs/1641828444

@mkoeppe mkoeppe modified the milestones: sage-9.6, sage-9.5 Dec 31, 2021
@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 31, 2021

Changed commit from 0644259 to 21afe51

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 31, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

21afe51.github/workflows/tox*.yml, tox.ini: Pass ddocker.pkg.github.com credentials via DOCKER_CONFIG_FILE

@mkoeppe

This comment has been minimized.

Sign in to view
@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 1, 2022

Changed reviewer from https://github.com/mkoeppe/sage/actions/runs/1641828444 to https://github.com/mkoeppe/sage/runs/4676511083?check_suite_focus=true

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 1, 2022

comment:13

This fixes the problem.

For example, https://github.com/mkoeppe/sage/runs/4676511083?check_suite_focus=true has just uploaded the image https://github.com/mkoeppe/sage/pkgs/container/sage%2Fsage-docker-ubuntu-trusty-minimal-configured

@dimpase
Copy link
Member

dimpase commented Jan 1, 2022

Changed reviewer from https://github.com/mkoeppe/sage/runs/4676511083?check_suite_focus=true to Dima Pasechnik

@dimpase
Copy link
Member

dimpase commented Jan 1, 2022

comment:14

OK, Happy New Year :-)

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Jan 1, 2022

comment:15

Thanks Dima, happy new year to you too!

@vbraun
Copy link
Member

vbraun commented Jan 30, 2022

Changed branch from u/mkoeppe/gh_actions__repair_upload_of_docker_images to 21afe51

@vbraun vbraun closed this as completed in fb599d0 Jan 30, 2022
@tobiasdiez tobiasdiez mentioned this issue Jan 8, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
c: porting p: blocker / 1 t: bug
Projects
None yet
Milestone
sage-9.5
Development

No branches or pull requests
3 participants
@vbraun @dimpase @mkoeppe