Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sage_setup: Replace imports from distutils by setuptools #30984

Closed
mkoeppe opened this issue Nov 30, 2020 · 28 comments
Closed

sage_setup: Replace imports from distutils by setuptools #30984

mkoeppe opened this issue Nov 30, 2020 · 28 comments

Comments

@mkoeppe
Copy link
Contributor

mkoeppe commented Nov 30, 2020

... in anticipation of the distutils deprecation (https://www.python.org/dev/peps/pep-0632/)

From https://setuptools.readthedocs.io/en/latest/deprecated/distutils-legacy.html

  • distutils.core.setupsetuptools.setup
  • distutils.cmd.Commandsetuptools.Command
  • distutils.log(no replacement yet)
  • distutils.version.*packaging.version.*

"If a project relies on uses of distutils that do not have a suitable replacement above, please search the Setuptools issue tracker and file a request, describing the use-case so that Setuptools’ maintainers can investigate."

Part of #31295 (Meta-ticket: Replace imports from deprecated distutils)

CC: @jhpalmieri @kiwifb @kliem

Component: build

Author: Frédéric Chapoton, Matthias Koeppe

Branch/Commit: 25b877c

Reviewer: Matthias Koeppe, John Palmieri

Issue created by migration from https://trac.sagemath.org/ticket/30984

@mkoeppe mkoeppe added this to the sage-9.3 milestone Nov 30, 2020
@mkoeppe

This comment has been minimized.

@mkoeppe

This comment has been minimized.

@fchapoton
Copy link
Contributor

Commit: 3b4203e

@fchapoton
Copy link
Contributor

Branch: public/distutils_to_setuptools

@fchapoton
Copy link
Contributor

New commits:

3b4203estart replacing distutils by setuptools

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 13, 2020

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

a29d068start replacing distutils by setuptools

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Dec 13, 2020

Changed commit from 3b4203e to a29d068

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2021

Author: Frédéric Chapoton

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2021

Changed commit from a29d068 to 673f99c

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

673f99cstart replacing distutils by setuptools

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2021

Changed author from Frédéric Chapoton to Frédéric Chapoton, Matthias Koeppe

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2021

Dependencies: #30912

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2021

Branch pushed to git repo; I updated commit sha1. Last 10 new commits:

2c40179build/pkgs/sagelib/src: Update metadata
2a91862build/pkgs/sagelib/src/README.rst: Add some text
6432727Merge tag '9.3.beta2' into t/30912/sagelib__update_metadata_for_pypi_deployment
4a693f2Move build/pkgs/sagelib/src/setup.cfg to SAGE_ROOT/src, replace by symlink
ea182d7Copy changes from build/pkgs/sagelib/src to src
a1a10b9src/VERSION.txt: New
5697335src/setup.cfg: Add license_file=LICENSE.txt
deb9eb3Merge tag '9.3.beta3' into t/30912/sagelib__update_metadata_for_pypi_deployment
7ad4c0eMerge tag '9.3.beta4' into t/30912/sagelib__update_metadata_for_pypi_deployment
3ab5982Merge branch 't/30912/sagelib__update_metadata_for_pypi_deployment' into t/30984/public/distutils_to_setuptools

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2021

Changed commit from 673f99c to 3ab5982

@mkoeppe

This comment has been minimized.

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2021

Changed commit from 3ab5982 to b3ea086

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2021

Branch pushed to git repo; I updated commit sha1. This was a forced push. New commits:

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2021

Changed dependencies from #30912 to none

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2021

Branch pushed to git repo; I updated commit sha1. New commits:

25b877csage_setup.command.build_ext: Use class from setuptools.command instead of distutils.command

@sagetrac-git
Copy link
Mannequin

sagetrac-git mannequin commented Feb 6, 2021

Changed commit from b3ea086 to 25b877c

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 6, 2021

Reviewer: Matthias Koeppe, ...

@jhpalmieri
Copy link
Member

comment:14

This works for me when building Sage and when upgrading sagelib from 9.3.beta6 to 9.3.beta7, or from building the develop branch to building this one. What else should I test?

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 12, 2021

comment:15

I've used it for a while now, I wouldn't know what else to test either.

@kiwifb
Copy link
Member

kiwifb commented Feb 12, 2021

comment:16

The title shows that the ticket is very specific, are there other tickets I have missed for:

  • setup.py
  • sage/misc/cython.py
  • sage/env.py
  • documentation mentioning distutils specifically

@mkoeppe

This comment has been minimized.

@jhpalmieri
Copy link
Member

Changed reviewer from Matthias Koeppe, ... to Matthias Koeppe, John Palmieri

@mkoeppe
Copy link
Contributor Author

mkoeppe commented Feb 16, 2021

comment:20

Thank you!

@vbraun
Copy link
Member

vbraun commented Mar 7, 2021

Changed branch from public/distutils_to_setuptools to 25b877c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants